----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11797/ -----------------------------------------------------------
(Updated June 21, 2013, 7:21 p.m.) Review request for oozie. Changes ------- Incorporated all comments by Rohini and Virag. Highlights: 1. Added catch block to confirmWithDB method 2. Reused JPA executors introduced in OOZIE=1424 instead of adding another one here 3. Setting job status, actual end, actual start on confirmation isMiss, as well as making sure further processing is disabled by removing from map 4. Diff r5-r6 will show additions due to rebased trunk. Description ------- https://issues.apache.org/jira/browse/OOZIE-1379 This addresses bug OOZIE-1379. https://issues.apache.org/jira/browse/OOZIE-1379 Diffs (updated) ----- trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1495515 trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1495515 trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java 1495515 trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java 1495515 trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java 1495515 trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java 1495515 trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java 1495515 trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryUpdateForSLAStatusActualTimesJPAExecutor.java 1495515 trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryUpdateForSLAStatusJPAExecutor.java 1495515 trunk/core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java 1495515 trunk/core/src/main/java/org/apache/oozie/sla/SLACalculator.java 1495515 trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 1495515 trunk/core/src/main/java/org/apache/oozie/sla/SLAOperations.java 1495515 trunk/core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java 1495515 trunk/core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java 1495515 trunk/core/src/test/java/org/apache/oozie/jms/TestJMSSLAEventListener.java 1495515 trunk/core/src/test/java/org/apache/oozie/servlet/TestV2SLAServlet.java 1495515 trunk/core/src/test/java/org/apache/oozie/sla/TestSLACalculationJPAExecutor.java 1495515 trunk/core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 1495515 trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEmailEventListener.java 1495515 trunk/core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java 1495515 trunk/core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetJPAExecutor.java 1495515 trunk/core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetRecordsOnRestartJPAExecutor.java 1495515 trunk/core/src/test/java/org/apache/oozie/sla/TestSLAService.java 1495515 trunk/core/src/test/java/org/apache/oozie/sla/TestSLASummaryGetOnRestartJPAExecutor.java 1495515 Diff: https://reviews.apache.org/r/11797/diff/ Testing ------- added unit test Thanks, Mona Chitnis
