-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11797/#review22127
-----------------------------------------------------------



trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java
<https://reviews.apache.org/r/11797/#comment45527>

    If there is any exception, log a warning and return true.



trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java
<https://reviews.apache.org/r/11797/#comment45528>

    Need to be removed from the map and not added to history set. Also 
eventProcessed needs to be updated to 8. 



trunk/core/src/test/java/org/apache/oozie/sla/TestSLAService.java
<https://reviews.apache.org/r/11797/#comment45529>

    not required


- Rohini Palaniswamy


On June 19, 2013, 2:04 a.m., Mona Chitnis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11797/
> -----------------------------------------------------------
> 
> (Updated June 19, 2013, 2:04 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-1379
> 
> 
> This addresses bug OOZIE-1379.
>     https://issues.apache.org/jira/browse/OOZIE-1379
> 
> 
> Diffs
> -----
> 
>   trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 
> 1494286 
>   trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1494286 
>   trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1494286 
>   trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java 1494286 
>   trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java 
> 1494286 
>   trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java 
> 1494286 
>   trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java 
> 1494286 
>   trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java 
> 1494286 
>   
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetForTimeStatusJPAExecutor.java
>  PRE-CREATION 
>   
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryUpdateForSLAStatusActualTimesJPAExecutor.java
>  1494286 
>   
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryUpdateForSLAStatusJPAExecutor.java
>  1494286 
>   trunk/core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java 1494286 
>   trunk/core/src/main/java/org/apache/oozie/sla/SLACalculator.java 1494286 
>   trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 
> 1494286 
>   trunk/core/src/main/java/org/apache/oozie/sla/SLAOperations.java 1494286 
>   trunk/core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java 
> 1494286 
>   trunk/core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java 1494286 
>   trunk/core/src/test/java/org/apache/oozie/jms/TestJMSSLAEventListener.java 
> 1494286 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestV2SLAServlet.java 
> 1494286 
>   
> trunk/core/src/test/java/org/apache/oozie/sla/TestSLACalculationJPAExecutor.java
>  1494286 
>   trunk/core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 
> 1494286 
>   
> trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEmailEventListener.java 
> 1494286 
>   trunk/core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java 
> 1494286 
>   
> trunk/core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetJPAExecutor.java
>  1494286 
>   
> trunk/core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetRecordsOnRestartJPAExecutor.java
>  1494286 
>   trunk/core/src/test/java/org/apache/oozie/sla/TestSLAService.java 1494286 
>   
> trunk/core/src/test/java/org/apache/oozie/sla/TestSLASummaryGetOnRestartJPAExecutor.java
>  1494286 
> 
> Diff: https://reviews.apache.org/r/11797/diff/
> 
> 
> Testing
> -------
> 
> added unit test
> 
> 
> Thanks,
> 
> Mona Chitnis
> 
>

Reply via email to