----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11797/#review22132 -----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java <https://reviews.apache.org/r/11797/#comment45537> if confirmWithDb returns false (lets say bcoz actualEndtime < expectedEndTime), wont this periodic check keep calling this function and make db calls till the terminal event is received? trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java <https://reviews.apache.org/r/11797/#comment45534> do we also need to set actual duration when start time and end time not null? trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java <https://reviews.apache.org/r/11797/#comment45538> you can reuse all wfjob, wfaction and coodaction jpa executors from OOZIE-1424. They only fetch parameters like start, end, status trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java <https://reviews.apache.org/r/11797/#comment45536> if coord is terminated, shouldn't actual start, end and duration be set? - Virag Kothari On June 19, 2013, 2:04 a.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11797/ > ----------------------------------------------------------- > > (Updated June 19, 2013, 2:04 a.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1379 > > > This addresses bug OOZIE-1379. > https://issues.apache.org/jira/browse/OOZIE-1379 > > > Diffs > ----- > > trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java > 1494286 > trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1494286 > trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1494286 > trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java 1494286 > trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java > 1494286 > trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java > 1494286 > trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java > 1494286 > trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java > 1494286 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetForTimeStatusJPAExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryUpdateForSLAStatusActualTimesJPAExecutor.java > 1494286 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryUpdateForSLAStatusJPAExecutor.java > 1494286 > trunk/core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java 1494286 > trunk/core/src/main/java/org/apache/oozie/sla/SLACalculator.java 1494286 > trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java > 1494286 > trunk/core/src/main/java/org/apache/oozie/sla/SLAOperations.java 1494286 > trunk/core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java > 1494286 > trunk/core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java 1494286 > trunk/core/src/test/java/org/apache/oozie/jms/TestJMSSLAEventListener.java > 1494286 > trunk/core/src/test/java/org/apache/oozie/servlet/TestV2SLAServlet.java > 1494286 > > trunk/core/src/test/java/org/apache/oozie/sla/TestSLACalculationJPAExecutor.java > 1494286 > trunk/core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java > 1494286 > > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEmailEventListener.java > 1494286 > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java > 1494286 > > trunk/core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetJPAExecutor.java > 1494286 > > trunk/core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetRecordsOnRestartJPAExecutor.java > 1494286 > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAService.java 1494286 > > trunk/core/src/test/java/org/apache/oozie/sla/TestSLASummaryGetOnRestartJPAExecutor.java > 1494286 > > Diff: https://reviews.apache.org/r/11797/diff/ > > > Testing > ------- > > added unit test > > > Thanks, > > Mona Chitnis > >
