-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13397/
-----------------------------------------------------------
(Updated Aug. 13, 2013, 5:14 a.m.)
Review request for oozie.
Changes
-------
1. Converted text-based file to store all action properties, into
SequenceFile<Text,Text> where key=type i.e. output.properties/newId/stat/error
etc and value is the properties/string.
2. Removed another redundant file action_prepare_xml by utilizing
action_conf_xml itself.
All unit tests pass except 4 in JavaActionExecutor because
Properties.load(Text.toString()) is not separating on proper key=value
delimiters. Minor issue which I'll debug in a day and shouldn't change the
logic much
Bugs: OOZIE-1486
https://issues.apache.org/jira/browse/OOZIE-1486
Repository: oozie
Description
-------
See JIRA Description
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/action/hadoop/HiveActionExecutor.java
1513230
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
1513230
trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapperHelper.java
1513230
trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java
1513230
trunk/core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java
1513230
trunk/core/src/main/java/org/apache/oozie/util/IOUtils.java 1513230
trunk/core/src/main/java/org/apache/oozie/util/PropertiesUtils.java 1513230
trunk/core/src/main/java/org/apache/oozie/util/StatusUtils.java 1513230
trunk/core/src/test/java/org/apache/oozie/action/hadoop/LauncherMainTester.java
1513230
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java
1513230
trunk/sharelib/hive/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java
1513230
trunk/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java
1513230
trunk/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/MapReduceMain.java
1513230
trunk/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/PrepareActionsDriver.java
1513230
trunk/sharelib/pig/src/main/java/org/apache/oozie/action/hadoop/PigMain.java
1513230
trunk/sharelib/sqoop/src/main/java/org/apache/oozie/action/hadoop/SqoopMain.java
1513230
Diff: https://reviews.apache.org/r/13397/diff/
Testing
-------
Existing unit tests should pass, and E-2-E test pending.
Few tests failing with a common problem of Properties object (for
output/new-id/error etc) getting stored in the file with Timestamp. Hence on
retrieval, it gives NPE on the expected keys. WIP to fix that small part
Thanks,
Mona Chitnis
