----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13397/#review25370 -----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java <https://reviews.apache.org/r/13397/#comment49760> Should not be removed. trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java <https://reviews.apache.org/r/13397/#comment49761> Add a comment saying fetching action output and stats for the Mapreduce action. Would make it clear for anyone working on id swap removal. trunk/sharelib/hive/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java <https://reviews.apache.org/r/13397/#comment49762> Can we retain the assert for external child ids? trunk/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java <https://reviews.apache.org/r/13397/#comment49763> Pass the actual exception also. trunk/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java <https://reviews.apache.org/r/13397/#comment49764> You also need to check for external child ids and store them on a action failure. Just not on errormessage == null trunk/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/MapReduceMain.java <https://reviews.apache.org/r/13397/#comment49768> You can just use FileOutputStream since it is only one line similar to the change done in SqoopMain trunk/sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java <https://reviews.apache.org/r/13397/#comment49765> can we have the equivalent assert added and also one for external child ids? trunk/sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java <https://reviews.apache.org/r/13397/#comment49766> can we have the equivalent assert added and also one for external child ids? trunk/sharelib/sqoop/src/main/java/org/apache/oozie/action/hadoop/SqoopMain.java <https://reviews.apache.org/r/13397/#comment49767> Can we use the constant in LauncherMapper here? trunk/sharelib/sqoop/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java <https://reviews.apache.org/r/13397/#comment49769> Would still be good to retain these asserts to catch any unexpected change till we remove id swap all together. - Rohini Palaniswamy On Aug. 21, 2013, 1:50 a.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13397/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2013, 1:50 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1486 > https://issues.apache.org/jira/browse/OOZIE-1486 > > > Repository: oozie > > > Description > ------- > > See JIRA Description > > > Diffs > ----- > > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/HiveActionExecutor.java > 1516008 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 1516008 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapperHelper.java > 1516008 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java > 1516008 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java > 1516008 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java > 1516008 > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java > 1516008 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java > 1516008 > > trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java > 1516008 > > trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java > 1516008 > trunk/core/src/test/java/org/apache/oozie/service/TestRecoveryService.java > 1516008 > > trunk/sharelib/hive/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java > 1516008 > > trunk/sharelib/hive/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java > 1516008 > > trunk/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java > 1516008 > > trunk/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/MapReduceMain.java > 1516008 > > trunk/sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java > 1516008 > > trunk/sharelib/sqoop/src/main/java/org/apache/oozie/action/hadoop/SqoopMain.java > 1516008 > > trunk/sharelib/sqoop/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java > 1516008 > > trunk/sharelib/streaming/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java > 1516008 > > Diff: https://reviews.apache.org/r/13397/diff/ > > > Testing > ------- > > E-2-E test with Pig stats verified. > > > Thanks, > > Mona Chitnis > >
