-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13397/#review25429
-----------------------------------------------------------



trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
<https://reviews.apache.org/r/13397/#comment49837>

    It is covered already in the function that follows - 
context.setExternalData - internally also calls action.setExternalStatus



trunk/sharelib/sqoop/src/main/java/org/apache/oozie/action/hadoop/SqoopMain.java
<https://reviews.apache.org/r/13397/#comment49838>

    Then makes sense to make change in all places where strings are used



trunk/sharelib/sqoop/src/main/java/org/apache/oozie/action/hadoop/SqoopMain.java
<https://reviews.apache.org/r/13397/#comment49839>

    Then makes sense to make the change across all files using strings for these


- Mona Chitnis


On Aug. 21, 2013, 1:50 a.m., Mona Chitnis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13397/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2013, 1:50 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1486
>     https://issues.apache.org/jira/browse/OOZIE-1486
> 
> 
> Repository: oozie
> 
> 
> Description
> -------
> 
> See JIRA Description
> 
> 
> Diffs
> -----
> 
>   
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/HiveActionExecutor.java
>  1516008 
>   
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
>  1516008 
>   
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapperHelper.java
>  1516008 
>   
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java
>  1516008 
>   
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java
>  1516008 
>   
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java
>  1516008 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java 
> 1516008 
>   
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java
>  1516008 
>   
> trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java
>  1516008 
>   
> trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java
>  1516008 
>   trunk/core/src/test/java/org/apache/oozie/service/TestRecoveryService.java 
> 1516008 
>   
> trunk/sharelib/hive/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java
>  1516008 
>   
> trunk/sharelib/hive/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java
>  1516008 
>   
> trunk/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java
>  1516008 
>   
> trunk/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/MapReduceMain.java
>  1516008 
>   
> trunk/sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java
>  1516008 
>   
> trunk/sharelib/sqoop/src/main/java/org/apache/oozie/action/hadoop/SqoopMain.java
>  1516008 
>   
> trunk/sharelib/sqoop/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java
>  1516008 
>   
> trunk/sharelib/streaming/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java
>  1516008 
> 
> Diff: https://reviews.apache.org/r/13397/diff/
> 
> 
> Testing
> -------
> 
> E-2-E test with Pig stats verified.
> 
> 
> Thanks,
> 
> Mona Chitnis
> 
>

Reply via email to