----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13397/#review25309 -----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java <https://reviews.apache.org/r/13397/#comment49665> Can you put this inside a null check block trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java <https://reviews.apache.org/r/13397/#comment49666> Do this reload only if actionData.containsKey(LauncherMapper.ACTION_DATA_NEW_ID) trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java <https://reviews.apache.org/r/13397/#comment49667> Why separately for sqoop? Should be fixed to be same for all. Fix SqoopMain Do not set childjob ids again in this block. trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java <https://reviews.apache.org/r/13397/#comment49675> Remove runningjob from the API trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java <https://reviews.apache.org/r/13397/#comment49668> Do not check counter. Check if actionData containskey trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapperHelper.java <https://reviews.apache.org/r/13397/#comment49669> Lets do counter for isMainSuccessful alone. Map<String, String> trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapperHelper.java <https://reviews.apache.org/r/13397/#comment49676> Remove runningjob trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapperHelper.java <https://reviews.apache.org/r/13397/#comment49670> local variable for Path for getActionData.. trunk/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java <https://reviews.apache.org/r/13397/#comment49673> Still need this counter. Lets just retain this one trunk/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java <https://reviews.apache.org/r/13397/#comment49672> commons-io is not in hadoop classpath in Hadoop 1.x - Rohini Palaniswamy On Aug. 19, 2013, 7:40 a.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13397/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2013, 7:40 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1486 > https://issues.apache.org/jira/browse/OOZIE-1486 > > > Repository: oozie > > > Description > ------- > > See JIRA Description > > > Diffs > ----- > > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/HiveActionExecutor.java > 1514596 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 1514596 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapperHelper.java > 1514596 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java > 1514596 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java > 1514596 > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java > 1514596 > > trunk/sharelib/hive/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java > 1514596 > > trunk/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java > 1514596 > > Diff: https://reviews.apache.org/r/13397/diff/ > > > Testing > ------- > > Existing unit tests should pass, and E-2-E test pending. > > Few tests failing with a common problem of Properties object (for > output/new-id/error etc) getting stored in the file with Timestamp. Hence on > retrieval, it gives NPE on the expected keys. WIP to fix that small part > > > Thanks, > > Mona Chitnis > >
