----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13397/#review25478 -----------------------------------------------------------
Just two more minor comments. trunk/sharelib/hive/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java <https://reviews.apache.org/r/13397/#comment49909> Add a assert not null check. If both are null also then assertEquals will be true. trunk/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java <https://reviews.apache.org/r/13397/#comment49910> Can remove this. You don't have to upload again here as you are doing it in map finally. It will be overwritten again in finally. - Rohini Palaniswamy On Aug. 22, 2013, 11:49 p.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13397/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2013, 11:49 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1486 > https://issues.apache.org/jira/browse/OOZIE-1486 > > > Repository: oozie > > > Description > ------- > > See JIRA Description > > > Diffs > ----- > > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/HiveActionExecutor.java > 1516594 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 1516594 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapperHelper.java > 1516594 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java > 1516594 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java > 1516594 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/LauncherMainTester.java > 1516594 > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java > 1516594 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceMain.java > 1516594 > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPipesMain.java > 1516594 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java > 1516594 > > trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java > 1516594 > > trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java > 1516594 > trunk/core/src/test/java/org/apache/oozie/service/TestRecoveryService.java > 1516594 > > trunk/sharelib/hive/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java > 1516594 > > trunk/sharelib/hive/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java > 1516594 > > trunk/sharelib/hive/src/test/java/org/apache/oozie/action/hadoop/TestHiveMain.java > 1516594 > > trunk/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java > 1516594 > > trunk/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/MapReduceMain.java > 1516594 > > trunk/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/ShellMain.java > 1516594 > > trunk/sharelib/pig/src/main/java/org/apache/oozie/action/hadoop/PigMain.java > 1516594 > > trunk/sharelib/pig/src/main/java/org/apache/oozie/action/hadoop/PigMainWithOldAPI.java > 1516594 > > trunk/sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java > 1516594 > > trunk/sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java > 1516594 > > trunk/sharelib/sqoop/src/main/java/org/apache/oozie/action/hadoop/SqoopMain.java > 1516594 > > trunk/sharelib/sqoop/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java > 1516594 > > trunk/sharelib/streaming/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java > 1516594 > > trunk/sharelib/streaming/src/test/java/org/apache/oozie/action/hadoop/TestStreamingMain.java > 1516594 > > Diff: https://reviews.apache.org/r/13397/diff/ > > > Testing > ------- > > E-2-E test with Pig stats verified. > > > Thanks, > > Mona Chitnis > >
