----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13931/#review25851 -----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java <https://reviews.apache.org/r/13931/#comment50413> Should still leave this as COMMON trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java <https://reviews.apache.org/r/13931/#comment50521> Have a static getCommonLauncherClasses method and make it return the common classes. trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java <https://reviews.apache.org/r/13931/#comment50415> Instead of this retain classes.addAll(Services.get().get(URIHandlerService.class).getClassesForLauncher()); trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java <https://reviews.apache.org/r/13931/#comment50473> Should not be trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java <https://reviews.apache.org/r/13931/#comment50491> getActionSystemLibCommonJars - Make this method return a string (variable at class level. needs to be loaded only once) of the comma separated list of jars. trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java <https://reviews.apache.org/r/13931/#comment50494> You can also get the filesystem from sharedlibservice trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java <https://reviews.apache.org/r/13931/#comment50492> getActionSystemLibDir - You can also make this return a cached string trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java <https://reviews.apache.org/r/13931/#comment50474> Why public? trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java <https://reviews.apache.org/r/13931/#comment50496> Add common sharelibs for Oozie and launcher jars trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java <https://reviews.apache.org/r/13931/#comment50497> addSystemShareLibForAction trunk/core/src/main/java/org/apache/oozie/service/ShareLibService.java <https://reviews.apache.org/r/13931/#comment50499> ShareLibService.temp.sharelib.retention.days trunk/core/src/main/java/org/apache/oozie/service/ShareLibService.java <https://reviews.apache.org/r/13931/#comment50501> Filesystem as local variable trunk/core/src/main/java/org/apache/oozie/service/ShareLibService.java <https://reviews.apache.org/r/13931/#comment50505> Do a set of strings to eliminate duplicates trunk/core/src/main/java/org/apache/oozie/service/ShareLibService.java <https://reviews.apache.org/r/13931/#comment50478> Do we need a set permission after this? trunk/core/src/main/java/org/apache/oozie/service/ShareLibService.java <https://reviews.apache.org/r/13931/#comment50477> IOException trunk/core/src/main/resources/oozie-default.xml <https://reviews.apache.org/r/13931/#comment50479> Do we need hdfs:/// ? trunk/core/src/test/java/org/apache/oozie/action/hadoop/ActionExecutorTestCase.java <https://reviews.apache.org/r/13931/#comment50480> Why public? - Rohini Palaniswamy On Sept. 2, 2013, 6:56 a.m., Virag Kothari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13931/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2013, 6:56 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1461 > https://issues.apache.org/jira/browse/OOZIE-1461 > > > Repository: oozie > > > Description > ------- > > Added sharelib service which uploads all sharelib jars containing launcher > classes to hdfs > JavaActionExecutor will add this to DC. > Sharelib service will always keep minimum 2 recent version of sharelib. Other > sharelibs older than 7 days (configurable) will be deleted. > > > Diffs > ----- > > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/DistcpActionExecutor.java > 1519337 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/HiveActionExecutor.java > 1519337 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 1519337 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java > 1519337 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java > 1519337 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/ScriptLanguageActionExecutor.java > 1519337 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/ShellActionExecutor.java > 1519337 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java > 1519337 > trunk/core/src/main/java/org/apache/oozie/service/ActionService.java > 1519337 > trunk/core/src/main/java/org/apache/oozie/service/ShareLibService.java > PRE-CREATION > trunk/core/src/main/resources/oozie-default.xml 1519337 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/ActionExecutorTestCase.java > 1519337 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java > 1519337 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java > 1519337 > trunk/core/src/test/java/org/apache/oozie/service/TestShareLibService.java > PRE-CREATION > trunk/core/src/test/java/org/apache/oozie/test/XFsTestCase.java 1519337 > trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1519337 > > trunk/sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java > 1519337 > > trunk/sharelib/sqoop/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java > 1519337 > > trunk/sharelib/streaming/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java > 1519337 > > trunk/sharelib/streaming/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutorUberJar.java > 1519337 > > Diff: https://reviews.apache.org/r/13931/diff/ > > > Testing > ------- > > Unit test case and ran pig, mapreduce examples > > > Thanks, > > Virag Kothari > >
