> On Sept. 6, 2013, 2:16 a.m., Mona Chitnis wrote: > > Does this mean the action lib jars also lie around in Oozie-server WEB-INF > > lib? Considering that is < 10 jars, that should be fine.
They were already in WEB-INF when sharelib refactoring was done. > On Sept. 6, 2013, 2:16 a.m., Mona Chitnis wrote: > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java, > > line 577 > > <https://reviews.apache.org/r/13931/diff/4/?file=348235#file348235line577> > > > > Can we add a debug level log statement here for all the JARs added This are the system level jars added by Sharelib service where we already have the log statements. So, doesn't seem to add much value as they will be always be the same. > On Sept. 6, 2013, 2:16 a.m., Mona Chitnis wrote: > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java, > > line 51 > > <https://reviews.apache.org/r/13931/diff/4/?file=348237#file348237line51> > > > > So we don't need this class OoziePigStats to be added anymore? we do findContainingJar in sharelibservice, so the jar which has ooziePigstats will be picked up as it also has the PigMain class > On Sept. 6, 2013, 2:16 a.m., Mona Chitnis wrote: > > trunk/core/src/main/java/org/apache/oozie/service/ShareLibService.java, > > line 186 > > <https://reviews.apache.org/r/13931/diff/4/?file=348242#file348242line186> > > > > How is "2" determined? Shouldn't we purge based on LRU? we first sort in desc order based on timestamp and then keep the latest two, so kind of LRU only - Virag ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13931/#review25951 ----------------------------------------------------------- On Sept. 5, 2013, 5:47 p.m., Virag Kothari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13931/ > ----------------------------------------------------------- > > (Updated Sept. 5, 2013, 5:47 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1461 > https://issues.apache.org/jira/browse/OOZIE-1461 > > > Repository: oozie > > > Description > ------- > > Added sharelib service which uploads all sharelib jars containing launcher > classes to hdfs > JavaActionExecutor will add this to DC. > Sharelib service will always keep minimum 2 recent version of sharelib. Other > sharelibs older than 7 days (configurable) will be deleted. > > > Diffs > ----- > > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/DistcpActionExecutor.java > 1520378 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/HiveActionExecutor.java > 1520378 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 1520378 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java > 1520378 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java > 1520378 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/ScriptLanguageActionExecutor.java > 1520378 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/ShellActionExecutor.java > 1520378 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java > 1520378 > trunk/core/src/main/java/org/apache/oozie/service/ActionService.java > 1520378 > trunk/core/src/main/java/org/apache/oozie/service/ShareLibService.java > PRE-CREATION > trunk/core/src/main/resources/oozie-default.xml 1520378 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/ActionExecutorTestCase.java > 1520378 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java > 1520378 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java > 1520378 > trunk/core/src/test/java/org/apache/oozie/service/TestShareLibService.java > PRE-CREATION > trunk/core/src/test/java/org/apache/oozie/test/XFsTestCase.java 1520378 > trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1520378 > > trunk/sharelib/hive/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java > 1520378 > > trunk/sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java > 1520378 > > trunk/sharelib/sqoop/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java > 1520378 > > trunk/sharelib/streaming/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java > 1520378 > > trunk/sharelib/streaming/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutorUberJar.java > 1520378 > > Diff: https://reviews.apache.org/r/13931/diff/ > > > Testing > ------- > > Unit test case and ran pig, mapreduce examples > > > Thanks, > > Virag Kothari > >
