> On Sept. 4, 2013, 6:36 p.m., Rohini Palaniswamy wrote: > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java, > > line 624 > > <https://reviews.apache.org/r/13931/diff/2/?file=347279#file347279line624> > > > > Why public?
Need for test case in TestShareLibService > On Sept. 4, 2013, 6:36 p.m., Rohini Palaniswamy wrote: > > trunk/core/src/main/resources/oozie-default.xml, line 1621 > > <https://reviews.apache.org/r/13931/diff/2/?file=347287#file347287line1621> > > > > Do we need hdfs:/// ? yes, ryota found that it was required. > On Sept. 4, 2013, 6:36 p.m., Rohini Palaniswamy wrote: > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/ActionExecutorTestCase.java, > > line 76 > > <https://reviews.apache.org/r/13931/diff/2/?file=347288#file347288line76> > > > > Why public? Need for test case in TestShareLibService - Virag ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13931/#review25851 ----------------------------------------------------------- On Sept. 4, 2013, 10:02 p.m., Virag Kothari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13931/ > ----------------------------------------------------------- > > (Updated Sept. 4, 2013, 10:02 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1461 > https://issues.apache.org/jira/browse/OOZIE-1461 > > > Repository: oozie > > > Description > ------- > > Added sharelib service which uploads all sharelib jars containing launcher > classes to hdfs > JavaActionExecutor will add this to DC. > Sharelib service will always keep minimum 2 recent version of sharelib. Other > sharelibs older than 7 days (configurable) will be deleted. > > > Diffs > ----- > > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/DistcpActionExecutor.java > 1519337 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/HiveActionExecutor.java > 1519337 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 1519337 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java > 1519337 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java > 1519337 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/ScriptLanguageActionExecutor.java > 1519337 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/ShellActionExecutor.java > 1519337 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java > 1519337 > trunk/core/src/main/java/org/apache/oozie/service/ActionService.java > 1519337 > trunk/core/src/main/java/org/apache/oozie/service/ShareLibService.java > PRE-CREATION > trunk/core/src/main/resources/oozie-default.xml 1519337 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/ActionExecutorTestCase.java > 1519337 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java > 1519337 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java > 1519337 > trunk/core/src/test/java/org/apache/oozie/service/TestShareLibService.java > PRE-CREATION > trunk/core/src/test/java/org/apache/oozie/test/XFsTestCase.java 1519337 > trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1519337 > > trunk/sharelib/hive/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java > 1519337 > > trunk/sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java > 1519337 > > trunk/sharelib/sqoop/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java > 1519337 > > trunk/sharelib/streaming/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java > 1519337 > > trunk/sharelib/streaming/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutorUberJar.java > 1519337 > > Diff: https://reviews.apache.org/r/13931/diff/ > > > Testing > ------- > > Unit test case and ran pig, mapreduce examples > > > Thanks, > > Virag Kothari > >
