----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13931/#review25951 -----------------------------------------------------------
Does this mean the action lib jars also lie around in Oozie-server WEB-INF lib? Considering that is < 10 jars, that should be fine. trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java <https://reviews.apache.org/r/13931/#comment50656> Can we add a debug level log statement here for all the JARs added trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java <https://reviews.apache.org/r/13931/#comment50657> So we don't need this class OoziePigStats to be added anymore? trunk/core/src/main/java/org/apache/oozie/service/ShareLibService.java <https://reviews.apache.org/r/13931/#comment50658> How is "2" determined? Shouldn't we purge based on LRU? - Mona Chitnis On Sept. 5, 2013, 5:47 p.m., Virag Kothari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13931/ > ----------------------------------------------------------- > > (Updated Sept. 5, 2013, 5:47 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1461 > https://issues.apache.org/jira/browse/OOZIE-1461 > > > Repository: oozie > > > Description > ------- > > Added sharelib service which uploads all sharelib jars containing launcher > classes to hdfs > JavaActionExecutor will add this to DC. > Sharelib service will always keep minimum 2 recent version of sharelib. Other > sharelibs older than 7 days (configurable) will be deleted. > > > Diffs > ----- > > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/DistcpActionExecutor.java > 1520378 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/HiveActionExecutor.java > 1520378 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 1520378 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java > 1520378 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java > 1520378 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/ScriptLanguageActionExecutor.java > 1520378 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/ShellActionExecutor.java > 1520378 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java > 1520378 > trunk/core/src/main/java/org/apache/oozie/service/ActionService.java > 1520378 > trunk/core/src/main/java/org/apache/oozie/service/ShareLibService.java > PRE-CREATION > trunk/core/src/main/resources/oozie-default.xml 1520378 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/ActionExecutorTestCase.java > 1520378 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java > 1520378 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java > 1520378 > trunk/core/src/test/java/org/apache/oozie/service/TestShareLibService.java > PRE-CREATION > trunk/core/src/test/java/org/apache/oozie/test/XFsTestCase.java 1520378 > trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1520378 > > trunk/sharelib/hive/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java > 1520378 > > trunk/sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java > 1520378 > > trunk/sharelib/sqoop/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java > 1520378 > > trunk/sharelib/streaming/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java > 1520378 > > trunk/sharelib/streaming/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutorUberJar.java > 1520378 > > Diff: https://reviews.apache.org/r/13931/diff/ > > > Testing > ------- > > Unit test case and ran pig, mapreduce examples > > > Thanks, > > Virag Kothari > >
