----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18257/#review34940 -----------------------------------------------------------
BundleStartXCommand's verifyPrecondition() needs to be changed as well. It only sees status = PREP and begins adding bundle actions again and submitting new coordinators. It should now also check about endtime being set. Add unit test covering this case core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java <https://reviews.apache.org/r/18257/#comment65330> We should atleast check for DateUtils.parseDate(endTime) here for any exceptions thrown by an invalid date. Check that this is done in a central place for starttime too. If not, add there too core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java <https://reviews.apache.org/r/18257/#comment65331> New 'what' date? specify pause/end to avoid ambiguity in this message. core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java <https://reviews.apache.org/r/18257/#comment65332> whitespace - Mona Chitnis On Feb. 19, 2014, 2:05 a.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18257/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2014, 2:05 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1703 > https://issues.apache.org/jira/browse/OOZIE-1703 > > > Repository: oozie-git > > > Description > ------- > > This is one of the important use-case in case of versioning. > > User can set end date of old coord/bundle before start date( if coord/bundle > is supposed to run in future), so that it doesn't run and user can safely > upload new version. > > > We should also lookahead at created actions that become invalid because of > the new end time. > These actions should be deleted from DB. > > > Diffs > ----- > > > core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java > cd2c844 > core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java > 4957330 > > core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java > b9bbf16 > docs/src/site/twiki/DG_CommandLineTool.twiki 0748ff8 > > Diff: https://reviews.apache.org/r/18257/diff/ > > > Testing > ------- > > > Thanks, > > Purshotam Shah > >
