> On March 17, 2014, 9:47 p.m., Rohini Palaniswamy wrote: > > core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java, > > line 102 > > <https://reviews.apache.org/r/18257/diff/3/?file=500330#file500330line102> > > > > The check is valid. Please revert this. If the bundle has not even > > started, user can always kill the bundle or suspend the bundle.
The purpose was to let user set end-date before start date. from JIRA. User can set end date of old coord/bundle before start date( if coord/bundle is supposed to run in future), so that it doesn't run and user can safely upload new version. > On March 17, 2014, 9:47 p.m., Rohini Palaniswamy wrote: > > core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java, > > line 236 > > <https://reviews.apache.org/r/18257/diff/3/?file=500331#file500331line236> > > > > Not required. lastActionNumber would be null and would not even come > > into this block I added it for test cases, the condition is valid and it doesn't harm. > On March 17, 2014, 9:47 p.m., Rohini Palaniswamy wrote: > > core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java, > > line 350 > > <https://reviews.apache.org/r/18257/diff/3/?file=500331#file500331line350> > > > > Why should we suspend? If the end time was changed again, the coord job > > will not automatically resume. Status is changed to SUCCEEDED, user can again set a new end date, which will make coord to go in running state. > On March 17, 2014, 9:47 p.m., Rohini Palaniswamy wrote: > > core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java, > > lines 171-175 > > <https://reviews.apache.org/r/18257/diff/3/?file=500330#file500330line171> > > > > This is not a valid use case. This block of code is not required. > > Please revert. > > > > Changing status of a bundle to suspend needs to be done through > > BundleSuspendXCommand as any coordinators started will have to be suspended. Agree, we will move it to succeeded state. - Purshotam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18257/#review37475 ----------------------------------------------------------- On March 31, 2014, 5:31 p.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18257/ > ----------------------------------------------------------- > > (Updated March 31, 2014, 5:31 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1703 > https://issues.apache.org/jira/browse/OOZIE-1703 > > > Repository: oozie-git > > > Description > ------- > > This is one of the important use-case in case of versioning. > > User can set end date of old coord/bundle before start date( if coord/bundle > is supposed to run in future), so that it doesn't run and user can safely > upload new version. > > > We should also lookahead at created actions that become invalid because of > the new end time. > These actions should be deleted from DB. > > > Diffs > ----- > > > core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java > cd2c844 > core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java > 5ecd5d5 > > core/src/test/java/org/apache/oozie/command/bundle/TestBundleChangeXCommand.java > 6560db6 > > core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java > fdc0a55 > docs/src/site/twiki/DG_CommandLineTool.twiki 351f0f2 > > Diff: https://reviews.apache.org/r/18257/diff/ > > > Testing > ------- > > > Thanks, > > Purshotam Shah > >
