> On March 17, 2014, 9:47 p.m., Rohini Palaniswamy wrote: > > core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java, > > line 358 > > <https://reviews.apache.org/r/18257/diff/3/?file=500331#file500331line358> > > > > Why do we need this?
Looks like you have added this to handle the case where you want to delete actions which are after the new end time but if they are in WAITING state. But there is no check for waiting state. If there are actions materialized after new end time and they are in running state, error needs to be thrown. It needs to be fixed for pause as well. - Rohini ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18257/#review37475 ----------------------------------------------------------- On Feb. 21, 2014, 10:26 p.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18257/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2014, 10:26 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1703 > https://issues.apache.org/jira/browse/OOZIE-1703 > > > Repository: oozie-git > > > Description > ------- > > This is one of the important use-case in case of versioning. > > User can set end date of old coord/bundle before start date( if coord/bundle > is supposed to run in future), so that it doesn't run and user can safely > upload new version. > > > We should also lookahead at created actions that become invalid because of > the new end time. > These actions should be deleted from DB. > > > Diffs > ----- > > > core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java > cd2c844 > core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java > 4957330 > > core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java > b9bbf16 > docs/src/site/twiki/DG_CommandLineTool.twiki 0748ff8 > > Diff: https://reviews.apache.org/r/18257/diff/ > > > Testing > ------- > > > Thanks, > > Purshotam Shah > >
