-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18257/#review38352
-----------------------------------------------------------



core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java
<https://reviews.apache.org/r/18257/#comment70435>

    Bundle status will be changes to succeeded.
    
    There is a below code which will issue change command for all child coords



core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
<https://reviews.apache.org/r/18257/#comment71245>

    It was a blunder. Thanks for catching that.



core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
<https://reviews.apache.org/r/18257/#comment70436>

    status will be changed to succeed



core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
<https://reviews.apache.org/r/18257/#comment70437>

    Added action check for lookahead


- Purshotam Shah


On March 31, 2014, 5:31 p.m., Purshotam Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18257/
> -----------------------------------------------------------
> 
> (Updated March 31, 2014, 5:31 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1703
>     https://issues.apache.org/jira/browse/OOZIE-1703
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> This is one of the important use-case in case of versioning.
> 
> User can set end date of old coord/bundle before start date( if coord/bundle 
> is supposed to run in future), so that it doesn't run and user can safely 
> upload new version.
> 
> 
> We should also lookahead at created actions that become invalid because of 
> the new end time.
> These actions should be deleted from DB.
> 
> 
> Diffs
> -----
> 
>   
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java
>  cd2c844 
>   core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 
> 5ecd5d5 
>   
> core/src/test/java/org/apache/oozie/command/bundle/TestBundleChangeXCommand.java
>  6560db6 
>   
> core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java
>  fdc0a55 
>   docs/src/site/twiki/DG_CommandLineTool.twiki 351f0f2 
> 
> Diff: https://reviews.apache.org/r/18257/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Purshotam Shah
> 
>

Reply via email to