----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24299/#review49880 -----------------------------------------------------------
client/src/main/java/org/apache/oozie/client/OozieClient.java <https://reviews.apache.org/r/24299/#comment87286> nominaltime or nominal_time - to be consistent with other filter params which don't use camel casing. I see that case does not matter later due to equalsIgnorecase check, but still just to keep naming consistent. core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java <https://reviews.apache.org/r/24299/#comment87287> To be removed core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java <https://reviews.apache.org/r/24299/#comment87288> unintended change? Needs to be reverted. core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java <https://reviews.apache.org/r/24299/#comment87289> Please remove this line docs/src/site/twiki/DG_CommandLineTool.twiki <https://reviews.apache.org/r/24299/#comment87290> default is 1000 docs/src/site/twiki/DG_CommandLineTool.twiki <https://reviews.apache.org/r/24299/#comment87291> Below changes can make the help a little more clear. - The comparators are not applicable for all keys. So need to clarify that =, != is applicable for status and =, !=, <, <=, >, >= applicable for nominaltime. - Would be good to have an example. docs/src/site/twiki/DG_CommandLineTool.twiki <https://reviews.apache.org/r/24299/#comment87292> Same comment as DG_CommandLineTool.twiki src/main/resources/checkstyle.xml <https://reviews.apache.org/r/24299/#comment87295> Where is this property defined? Not able to find it in code base. - Rohini Palaniswamy On Aug. 5, 2014, 6:52 a.m., shwethags wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24299/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2014, 6:52 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1950 > https://issues.apache.org/jira/browse/OOZIE-1950 > > > Repository: oozie-git > > > Description > ------- > > Adds filter on nominal time in get coord actions > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/client/OozieClient.java b468186 > core/src/main/java/org/apache/oozie/CoordinatorEngine.java dd5c703 > core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java > 5eaf062 > > core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java > a531798 > core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 855fabc > core/src/test/java/org/apache/oozie/TestCoordinatorEngineSimple.java > 1904519 > > core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java > 147bdb7 > docs/src/site/twiki/DG_CommandLineTool.twiki 4a07711 > pom.xml be5e84a > src/main/resources/checkstyle.xml b75d737 > > Diff: https://reviews.apache.org/r/24299/diff/ > > > Testing > ------- > > UTs > > > Thanks, > > shwethags > >
