> On Aug. 7, 2014, 8:34 a.m., Rohini Palaniswamy wrote: > > core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java, > > lines 126-127 > > <https://reviews.apache.org/r/24299/diff/1/?file=651741#file651741line126> > > > > To be removed
yes, will remove > On Aug. 7, 2014, 8:34 a.m., Rohini Palaniswamy wrote: > > client/src/main/java/org/apache/oozie/client/OozieClient.java, line 125 > > <https://reviews.apache.org/r/24299/diff/1/?file=651738#file651738line125> > > > > nominaltime or nominal_time - to be consistent with other filter params > > which don't use camel casing. I see that case does not matter later due to > > equalsIgnorecase check, but still just to keep naming consistent. will rename > On Aug. 7, 2014, 8:34 a.m., Rohini Palaniswamy wrote: > > core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java, line 827 > > <https://reviews.apache.org/r/24299/diff/1/?file=651742#file651742line827> > > > > unintended change? Needs to be reverted. Is this intentional of not returning any actions by default? Even some user had questions on why its not returning any actions and then he had to set len > On Aug. 7, 2014, 8:34 a.m., Rohini Palaniswamy wrote: > > core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java, > > line 89 > > <https://reviews.apache.org/r/24299/diff/1/?file=651744#file651744line89> > > > > Please remove this line ok > On Aug. 7, 2014, 8:34 a.m., Rohini Palaniswamy wrote: > > docs/src/site/twiki/DG_CommandLineTool.twiki, line 43 > > <https://reviews.apache.org/r/24299/diff/1/?file=651745#file651745line43> > > > > default is 1000 Its 0 in V1JobServlet.java > On Aug. 7, 2014, 8:34 a.m., Rohini Palaniswamy wrote: > > docs/src/site/twiki/DG_CommandLineTool.twiki, line 45 > > <https://reviews.apache.org/r/24299/diff/1/?file=651745#file651745line45> > > > > Below changes can make the help a little more clear. > > > > - The comparators are not applicable for all keys. So need to clarify > > that =, != is applicable for status and =, !=, <, <=, >, >= applicable for > > nominaltime. > > - Would be good to have an example. > > All comparators apply on all keys. = applies on nominal time to get single action. Just like in sql Example is in later section of filter > On Aug. 7, 2014, 8:34 a.m., Rohini Palaniswamy wrote: > > src/main/resources/checkstyle.xml, line 31 > > <https://reviews.apache.org/r/24299/diff/1/?file=651747#file651747line31> > > > > Where is this property defined? Not able to find it in code base. in main pom.xml. This helps to build each module separately - shwethags ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24299/#review49880 ----------------------------------------------------------- On Aug. 5, 2014, 6:52 a.m., shwethags wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24299/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2014, 6:52 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1950 > https://issues.apache.org/jira/browse/OOZIE-1950 > > > Repository: oozie-git > > > Description > ------- > > Adds filter on nominal time in get coord actions > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/client/OozieClient.java b468186 > core/src/main/java/org/apache/oozie/CoordinatorEngine.java dd5c703 > core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java > 5eaf062 > > core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java > a531798 > core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 855fabc > core/src/test/java/org/apache/oozie/TestCoordinatorEngineSimple.java > 1904519 > > core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java > 147bdb7 > docs/src/site/twiki/DG_CommandLineTool.twiki 4a07711 > pom.xml be5e84a > src/main/resources/checkstyle.xml b75d737 > > Diff: https://reviews.apache.org/r/24299/diff/ > > > Testing > ------- > > UTs > > > Thanks, > > shwethags > >
