> On Aug. 8, 2014, 8:33 a.m., Purshotam Shah wrote: > > core/src/main/java/org/apache/oozie/CoordinatorEngine.java, line 37 > > <https://reviews.apache.org/r/24299/diff/1/?file=651739#file651739line37> > > > > Why Hbase util? This means that Oozie always need have hbase-*.jar, > > which might cause other conflict.
Pair is defined in a lot of dependent jars. So, wanted to re-use instead of defining our own. If we remove hbase dependency, we can switch to others or define our own. Looks ok for now > On Aug. 8, 2014, 8:33 a.m., Purshotam Shah wrote: > > core/src/main/java/org/apache/oozie/CoordinatorEngine.java, line 636 > > <https://reviews.apache.org/r/24299/diff/1/?file=651739#file651739line636> > > > > when user pass status as > > status=<S1>[;status=<S2>] > > > > Then it should as check for both status. > > > > Eg. status=RUNNING;status=RUNNINGWITHERROR > > > > Should return all status matching RUNNING or RUNNINGWITHERROR. > > > > Not sure if it's happening here. > > > > From Doc. > > "-filter <arg> status=<S1>[;status=<S2>]* or > > status!=<S1>[;status!=<S2>]* > > All coordinator actions > > satisfying the status filters will be retrieved. > > Positive filters '=' concatenated > > with 'OR' and negative filters '!=' with 'AND'." > > Its handled correctly: + case EQUALS: + sb.append("IN ("); + params.putAll(appendParams(sb, filter.getValue(), pcnt)); + sb.append(")"); + break; - shwethags ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24299/#review50019 ----------------------------------------------------------- On Aug. 5, 2014, 6:52 a.m., shwethags wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24299/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2014, 6:52 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1950 > https://issues.apache.org/jira/browse/OOZIE-1950 > > > Repository: oozie-git > > > Description > ------- > > Adds filter on nominal time in get coord actions > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/client/OozieClient.java b468186 > core/src/main/java/org/apache/oozie/CoordinatorEngine.java dd5c703 > core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java > 5eaf062 > > core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java > a531798 > core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 855fabc > core/src/test/java/org/apache/oozie/TestCoordinatorEngineSimple.java > 1904519 > > core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java > 147bdb7 > docs/src/site/twiki/DG_CommandLineTool.twiki 4a07711 > pom.xml be5e84a > src/main/resources/checkstyle.xml b75d737 > > Diff: https://reviews.apache.org/r/24299/diff/ > > > Testing > ------- > > UTs > > > Thanks, > > shwethags > >
