> On Aug. 7, 2014, 8:34 a.m., Rohini Palaniswamy wrote: > > src/main/resources/checkstyle.xml, line 31 > > <https://reviews.apache.org/r/24299/diff/1/?file=651747#file651747line31> > > > > Where is this property defined? Not able to find it in code base. > > shwethags wrote: > in main pom.xml. This helps to build each module separately > > Rohini Palaniswamy wrote: > The main pom.xml does not have checkstyle.header.file defined currently. > I did search *.xml file in codebase. > > shwethags wrote: > The change in pom.xml: > <headerLocation>src/main/resources/checkstyle-header.txt</headerLocation>
Sorry. Should have checked the checkstyle maven plugin documentation. Can we remove the checkstyle changes out of this patch and keep them in the newly created checkstyle jiras? > On Aug. 7, 2014, 8:34 a.m., Rohini Palaniswamy wrote: > > docs/src/site/twiki/DG_CommandLineTool.twiki, line 45 > > <https://reviews.apache.org/r/24299/diff/1/?file=651745#file651745line45> > > > > Below changes can make the help a little more clear. > > > > - The comparators are not applicable for all keys. So need to clarify > > that =, != is applicable for status and =, !=, <, <=, >, >= applicable for > > nominaltime. > > - Would be good to have an example. > > > > shwethags wrote: > All comparators apply on all keys. = applies on nominal time to get > single action. Just like in sql > > Example is in later section of filter > > Rohini Palaniswamy wrote: > For status, only = and != makes sense. > > shwethags wrote: > Yes, but with adding more keys in the filter, this will become > complicated conditions. So, we can leave it as is? Don't have to change code. But can we at least change documentation and state that = and != are to be used for status? It would be confusing for users and there will be too smart people who will assume and expect that STATUS>WAITING should contain statuses after PREP and WAITING based on state transitions. - Rohini ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24299/#review49880 ----------------------------------------------------------- On Aug. 5, 2014, 6:52 a.m., shwethags wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24299/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2014, 6:52 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1950 > https://issues.apache.org/jira/browse/OOZIE-1950 > > > Repository: oozie-git > > > Description > ------- > > Adds filter on nominal time in get coord actions > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/client/OozieClient.java b468186 > core/src/main/java/org/apache/oozie/CoordinatorEngine.java dd5c703 > core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java > 5eaf062 > > core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java > a531798 > core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 855fabc > core/src/test/java/org/apache/oozie/TestCoordinatorEngineSimple.java > 1904519 > > core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java > 147bdb7 > docs/src/site/twiki/DG_CommandLineTool.twiki 4a07711 > pom.xml be5e84a > src/main/resources/checkstyle.xml b75d737 > > Diff: https://reviews.apache.org/r/24299/diff/ > > > Testing > ------- > > UTs > > > Thanks, > > shwethags > >
