----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28842/#review68473 -----------------------------------------------------------
Review comments for Page 1 and documentation client/src/main/java/org/apache/oozie/cli/OozieCLI.java <https://reviews.apache.org/r/28842/#comment112714> To be removed client/src/main/java/org/apache/oozie/cli/OozieCLI.java <https://reviews.apache.org/r/28842/#comment112741> disables client/src/main/java/org/apache/oozie/cli/OozieCLI.java <https://reviews.apache.org/r/28842/#comment112742> enables client/src/main/java/org/apache/oozie/cli/OozieCLI.java <https://reviews.apache.org/r/28842/#comment112729> No value specified for -coordinator option client/src/main/java/org/apache/oozie/client/OozieClient.java <https://reviews.apache.org/r/28842/#comment112730> Do not remove client/src/main/java/org/apache/oozie/client/OozieClient.java <https://reviews.apache.org/r/28842/#comment112731> SLA_DISABLE_ALERT = ....disable.alerts client/src/main/java/org/apache/oozie/client/OozieClient.java <https://reviews.apache.org/r/28842/#comment112737> coordId the coordinator job id actionIds Comma separated list of action ids or action id ranges. dates Comma separated list of the nominal times Param and javadoc change for other overloaded methods too. client/src/main/java/org/apache/oozie/client/OozieClient.java <https://reviews.apache.org/r/28842/#comment112733> coordinators client/src/main/java/org/apache/oozie/client/OozieClient.java <https://reviews.apache.org/r/28842/#comment112738> Give an example here client/src/main/java/org/apache/oozie/client/event/jms/JMSHeaderConstants.java <https://reviews.apache.org/r/28842/#comment112739> Can we use jobId instead of coordId so that it can be used for workflows as well? core/src/main/java/org/apache/oozie/BundleEngine.java <https://reviews.apache.org/r/28842/#comment112743> Rename classes to BundleSLAAlertsEnableXCommand BundleSLAAlertsDisableXCommand BundleSLAChangeXCommand core/src/main/java/org/apache/oozie/CoordinatorEngine.java <https://reviews.apache.org/r/28842/#comment112744> Rename classes to CoordSLAAlertsEnableXCommand CoordSLAAlertsDisableXCommand CoordSLAChangeXCommand core/src/main/java/org/apache/oozie/ErrorCode.java <https://reviews.apache.org/r/28842/#comment112745> failed: core/src/main/java/org/apache/oozie/command/SlaAlertsXCommand.java <https://reviews.apache.org/r/28842/#comment112750> SLAXCommand core/src/main/java/org/apache/oozie/command/bundle/BundleDisableSlaAlertsXCommand.java <https://reviews.apache.org/r/28842/#comment112751> Do we need two different classes in Bundle and Coord for enable and disable? Can't we just pass a boolean to the constructor ? core/src/main/java/org/apache/oozie/command/coord/CoordChangeSlaAlertsXCommand.java <https://reviews.apache.org/r/28842/#comment112756> Please parse newParams here and call slaChange with method args for each param (duration, start, end, etc) Are EL functions evaluated for should-start, should-end, etc? docs/src/site/twiki/DG_CommandLineTool.twiki <https://reviews.apache.org/r/28842/#comment112727> Make this a section and link into DG_SLAMonitoring.twiki DG_SLAMonitoring.twiki: - Mention that alerting for 2 day old is not done. - Disabling while submission documention - Document the REST API as well docs/src/site/twiki/DG_CommandLineTool.twiki <https://reviews.apache.org/r/28842/#comment112723> Eg: docs/src/site/twiki/DG_CommandLineTool.twiki <https://reviews.apache.org/r/28842/#comment112725> Document the case where you disable or enable for all docs/src/site/twiki/DG_CommandLineTool.twiki <https://reviews.apache.org/r/28842/#comment112718> 1) sla_enable. _ is missing. Same for all other commands. 2) Remove spaces after , in action and date docs/src/site/twiki/DG_CommandLineTool.twiki <https://reviews.apache.org/r/28842/#comment112726> Give this example with all values for -value docs/src/site/twiki/DG_CommandLineTool.twiki <https://reviews.apache.org/r/28842/#comment112719> ending > is missing webapp/src/main/webapp/console/sla/oozie-sla.html <https://reviews.apache.org/r/28842/#comment112722> Status can be removed to keep the column size small. Can keep slaAlertStatus in response as is. - Rohini Palaniswamy On Jan. 15, 2015, 2:01 a.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28842/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2015, 2:01 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1913 > https://issues.apache.org/jira/browse/OOZIE-1913 > > > Repository: oozie-git > > > Description > ------- > > OOZIE-1913 Devise a way to turn off SLA alerts for bundle/coordinator flexibly > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/cli/OozieCLI.java bc8fa50 > client/src/main/java/org/apache/oozie/client/OozieClient.java 800e871 > > client/src/main/java/org/apache/oozie/client/event/jms/JMSHeaderConstants.java > 801ad7e > client/src/main/java/org/apache/oozie/client/rest/JsonTags.java b7cf0e7 > client/src/main/java/org/apache/oozie/client/rest/RestConstants.java > 85efecf > core/src/main/java/org/apache/oozie/BaseEngine.java a982ad4 > core/src/main/java/org/apache/oozie/BundleEngine.java 27afe73 > core/src/main/java/org/apache/oozie/CoordinatorEngine.java 3406c6f > core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 4d6b970 > core/src/main/java/org/apache/oozie/DagEngine.java 70ddd44 > core/src/main/java/org/apache/oozie/ErrorCode.java 4444c87 > core/src/main/java/org/apache/oozie/command/SlaAlertsXCommand.java e69de29 > > core/src/main/java/org/apache/oozie/command/bundle/BundleChangeSlaAlertsXCommand.java > e69de29 > > core/src/main/java/org/apache/oozie/command/bundle/BundleDisableSlaAlertsXCommand.java > e69de29 > > core/src/main/java/org/apache/oozie/command/bundle/BundleEnableSlaAlertsXCommand.java > e69de29 > > core/src/main/java/org/apache/oozie/command/bundle/BundleSlaAlertsXCommand.java > e69de29 > > core/src/main/java/org/apache/oozie/command/coord/CoordChangeSlaAlertsXCommand.java > e69de29 > > core/src/main/java/org/apache/oozie/command/coord/CoordDisableSlaAlertsXCommand.java > e69de29 > > core/src/main/java/org/apache/oozie/command/coord/CoordEnableSlaAlertsXCommand.java > e69de29 > > core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > 548946f > > core/src/main/java/org/apache/oozie/command/coord/CoordSlaAlertsXCommand.java > e69de29 > core/src/main/java/org/apache/oozie/coord/CoordUtils.java 4643d73 > core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java > 4bccef4 > > core/src/main/java/org/apache/oozie/executor/jpa/SLARegistrationQueryExecutor.java > e220c01 > > core/src/main/java/org/apache/oozie/executor/jpa/SLASummaryQueryExecutor.java > c3197b7 > core/src/main/java/org/apache/oozie/jms/JMSSLAEventListener.java c19839f > > core/src/main/java/org/apache/oozie/service/CoordMaterializeTriggerService.java > fa16d1d > core/src/main/java/org/apache/oozie/service/EventHandlerService.java > 7c0d3be > core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java c94d1e2 > core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 2578e41 > core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java b160b46 > core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java eed7ca1 > core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java da81b49 > core/src/main/java/org/apache/oozie/servlet/V2SLAServlet.java a0fe1b6 > core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java 189d5ea > core/src/main/java/org/apache/oozie/sla/SLACalculator.java 20f93b5 > core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java fdce6b5 > core/src/main/java/org/apache/oozie/sla/SLAOperations.java f5fc826 > core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java 0770bd3 > core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java 9907dd0 > core/src/main/java/org/apache/oozie/sla/service/SLAService.java a4562e7 > core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java > 7c2620c > core/src/main/resources/oozie-default.xml e849fc7 > core/src/test/java/org/apache/oozie/command/TestSlaAlertCommand.java > e69de29 > > core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java > 5ce9a7f > core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java ae3f18d > core/src/test/java/org/apache/oozie/jms/TestJMSSLAEventListener.java > 30fd151 > core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java > c70ef79 > core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java ea82baa > > core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetJPAExecutor.java > fe9002c > core/src/test/resources/coord-action-sla.xml 8b301fd > docs/src/site/twiki/DG_CommandLineTool.twiki 4ac73f9 > webapp/src/main/webapp/console/sla/js/oozie-sla-table.js 1a88671 > webapp/src/main/webapp/console/sla/oozie-sla.html 23e8af2 > > Diff: https://reviews.apache.org/r/28842/diff/ > > > Testing > ------- > > UTC > > > Thanks, > > Purshotam Shah > >
