> On Jan. 16, 2015, 10:28 p.m., Rohini Palaniswamy wrote: > > client/src/main/java/org/apache/oozie/client/OozieClient.java, lines > > 1613-1615 > > <https://reviews.apache.org/r/28842/diff/3/?file=822303#file822303line1613> > > > > coordId the coordinator job id > > actionIds Comma separated list of action ids or action id ranges. > > dates Comma separated list of the nominal times > > > > Param and javadoc change for other overloaded methods too. > > Purshotam Shah wrote: > >coordId the coordinator job id > JobId can be bundle id also without coord name/id. > @param jobIds the job ids is correct.
Since you have another API with first one as bundleId, make this as the coordId. Add a @Nullable to coords. > On Jan. 16, 2015, 10:28 p.m., Rohini Palaniswamy wrote: > > core/src/main/java/org/apache/oozie/command/SlaAlertsXCommand.java, line 25 > > <https://reviews.apache.org/r/28842/diff/3/?file=822313#file822313line25> > > > > SLAXCommand > > Purshotam Shah wrote: > SLAXCommand will be confusing name, there are other SLACommand and > SlaAlertsXCommand is only for sla alertcommand. So SLAXCommand will > incorrect and give wrong meaning. No problem. But can we make capitalize SLA. i.e SLAAlertsXCommand > On Jan. 16, 2015, 10:28 p.m., Rohini Palaniswamy wrote: > > core/src/main/java/org/apache/oozie/command/bundle/BundleDisableSlaAlertsXCommand.java, > > line 24 > > <https://reviews.apache.org/r/28842/diff/3/?file=822315#file822315line24> > > > > Do we need two different classes in Bundle and Coord for enable and > > disable? Can't we just pass a boolean to the constructor ? > > Purshotam Shah wrote: > Yes, both classes have different implementation. Bundle loads bundle job > find out all coords and call coordCommand to perform SLA operation. Not asking to combine bundle and coord commands. But asking to combine BundleSLAAlertDisableXCommand and BundleSLAAlertEnableXCommand as there is duplication of code. Same for coordinator. > On Jan. 16, 2015, 10:28 p.m., Rohini Palaniswamy wrote: > > client/src/main/java/org/apache/oozie/client/event/jms/JMSHeaderConstants.java, > > line 34 > > <https://reviews.apache.org/r/28842/diff/3/?file=822304#file822304line34> > > > > Can we use jobId instead of coordId so that it can be used for > > workflows as well? Needs to be removed - Rohini ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28842/#review68473 ----------------------------------------------------------- On Jan. 26, 2015, 11:14 p.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28842/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2015, 11:14 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1913 > https://issues.apache.org/jira/browse/OOZIE-1913 > > > Repository: oozie-git > > > Description > ------- > > OOZIE-1913 Devise a way to turn off SLA alerts for bundle/coordinator flexibly > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/cli/OozieCLI.java bc8fa50 > client/src/main/java/org/apache/oozie/client/OozieClient.java 800e871 > > client/src/main/java/org/apache/oozie/client/event/jms/JMSHeaderConstants.java > 801ad7e > client/src/main/java/org/apache/oozie/client/rest/JsonTags.java b7cf0e7 > client/src/main/java/org/apache/oozie/client/rest/RestConstants.java > 85efecf > core/src/main/java/org/apache/oozie/BaseEngine.java a982ad4 > core/src/main/java/org/apache/oozie/BundleEngine.java 27afe73 > core/src/main/java/org/apache/oozie/CoordinatorActionBean.java bd01d14 > core/src/main/java/org/apache/oozie/CoordinatorEngine.java 3406c6f > core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 4d6b970 > core/src/main/java/org/apache/oozie/DagEngine.java 70ddd44 > core/src/main/java/org/apache/oozie/ErrorCode.java 4444c87 > core/src/main/java/org/apache/oozie/command/SlaAlertsXCommand.java e69de29 > > core/src/main/java/org/apache/oozie/command/bundle/BundleSLAAlertsDisableXCommand.java > e69de29 > > core/src/main/java/org/apache/oozie/command/bundle/BundleSLAAlertsEnableXCommand.java > e69de29 > > core/src/main/java/org/apache/oozie/command/bundle/BundleSLAChangeXCommand.java > e69de29 > > core/src/main/java/org/apache/oozie/command/bundle/BundleSlaAlertsXCommand.java > e69de29 > > core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > 548946f > > core/src/main/java/org/apache/oozie/command/coord/CoordSLAAlertsDisableXCommand.java > e69de29 > > core/src/main/java/org/apache/oozie/command/coord/CoordSLAAlertsEnableXCommand.java > e69de29 > > core/src/main/java/org/apache/oozie/command/coord/CoordSLAChangeXCommand.java > e69de29 > > core/src/main/java/org/apache/oozie/command/coord/CoordSlaAlertsXCommand.java > e69de29 > core/src/main/java/org/apache/oozie/coord/CoordUtils.java 4643d73 > > core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java > e6ab09b > core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java > 4bccef4 > > core/src/main/java/org/apache/oozie/executor/jpa/SLARegistrationQueryExecutor.java > e220c01 > > core/src/main/java/org/apache/oozie/executor/jpa/SLASummaryQueryExecutor.java > c3197b7 > > core/src/main/java/org/apache/oozie/service/CoordMaterializeTriggerService.java > fa16d1d > core/src/main/java/org/apache/oozie/service/EventHandlerService.java > 7c0d3be > core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java c94d1e2 > core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 2578e41 > core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java b160b46 > core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java eed7ca1 > core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java da81b49 > core/src/main/java/org/apache/oozie/servlet/V2SLAServlet.java a0fe1b6 > core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java 189d5ea > core/src/main/java/org/apache/oozie/sla/SLACalculator.java 20f93b5 > core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java fdce6b5 > core/src/main/java/org/apache/oozie/sla/SLAOperations.java f5fc826 > core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java 0770bd3 > core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java 9907dd0 > core/src/main/java/org/apache/oozie/sla/service/SLAService.java a4562e7 > core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java > 7c2620c > core/src/main/resources/oozie-default.xml e849fc7 > core/src/test/java/org/apache/oozie/command/TestSlaAlertCommand.java > e69de29 > > core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java > 5ce9a7f > core/src/test/java/org/apache/oozie/servlet/TestV2SLAServlet.java 5f51b22 > core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java > c70ef79 > core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java ea82baa > > core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetJPAExecutor.java > fe9002c > core/src/test/resources/coord-action-sla.xml 8b301fd > docs/src/site/twiki/DG_CommandLineTool.twiki 4ac73f9 > docs/src/site/twiki/DG_SLAMonitoring.twiki acf8ac1 > docs/src/site/twiki/WebServicesAPI.twiki fc51934 > webapp/src/main/webapp/console/sla/js/oozie-sla-table.js 1a88671 > webapp/src/main/webapp/console/sla/oozie-sla.html 23e8af2 > > Diff: https://reviews.apache.org/r/28842/diff/ > > > Testing > ------- > > UTC > > > Thanks, > > Purshotam Shah > >
