[ 
https://issues.apache.org/jira/browse/OOZIE-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14552878#comment-14552878
 ] 

Rohini Palaniswamy commented on OOZIE-2030:
-------------------------------------------

[~jaydeepvishwakarma],
    I had comments in the review board on the approach taken by Shwetha in her 
patch. The patch needs to be reworked a lot. Please refer to my comments there. 
Parsing global-xml should not be done in ActionExecutor classes. It is the 
wrong place to do and is also inefficient. It should be done when the 
sub-workflow action is constructed and stored similar to other workflow 
actions. That will also make the config to be shown in the Action Configuration 
section. Will avoid your testcase problems as well.

> Configuration properties from global section is not getting set in Hadoop job 
> conf when using sub-workflow action in Oozie workflow.xml 
> ----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OOZIE-2030
>                 URL: https://issues.apache.org/jira/browse/OOZIE-2030
>             Project: Oozie
>          Issue Type: Bug
>          Components: action
>            Reporter: Peeyush Bishnoi
>            Assignee: Jaydeep Vishwakarma
>         Attachments: OOZIE-2030-v2.patch, OOZIE-2030.patch
>
>
> When submitting Oozie workflow with sub-workflow action and with global 
> section, configuration properties defined in global section is not getting 
> set in launched Hadoop job conf. But when we use Pig or MR action in 
> workflow.xml, configuration properties from global section set properly into 
> Hadoop job conf.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to