[ 
https://issues.apache.org/jira/browse/OOZIE-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14558670#comment-14558670
 ] 

Rohini Palaniswamy commented on OOZIE-2030:
-------------------------------------------

You do not have to make changes to LiteWorkflowAppParser.java.  My last comment 
was to modify the <global> xml element of sub-workflow in 
SubWorkflowActionExecutor.java itself to include (merge) the parent workflows 
global configuration if propagate-configuration is true. That would be similar 
to how the <configuration> xml element of sub-workflow is modified to include 
the parentw workflows configuration properties as well. Your patch prints the 
<global> section into a configuration and parses that later. This is not needed 
and will not work correctly with multiple levels of sub-workflows. Please 
modify the <global> xml  in SubWorkflowActionExecutor.java itself.  Also 
sub-workflow's global conf (both job.xml and configuration property) should 
have precedence over the parent's. From your current patch looks like the 
parent will have precedence. Ensure you have a test case for that.

> Configuration properties from global section is not getting set in Hadoop job 
> conf when using sub-workflow action in Oozie workflow.xml 
> ----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OOZIE-2030
>                 URL: https://issues.apache.org/jira/browse/OOZIE-2030
>             Project: Oozie
>          Issue Type: Bug
>          Components: action
>            Reporter: Peeyush Bishnoi
>            Assignee: Jaydeep Vishwakarma
>         Attachments: OOZIE-2030-v2.patch, OOZIE-2030-v3.patch, 
> OOZIE-2030.patch
>
>
> When submitting Oozie workflow with sub-workflow action and with global 
> section, configuration properties defined in global section is not getting 
> set in launched Hadoop job conf. But when we use Pig or MR action in 
> workflow.xml, configuration properties from global section set properly into 
> Hadoop job conf.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to