[
https://issues.apache.org/jira/browse/OOZIE-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15726696#comment-15726696
]
Hadoop QA commented on OOZIE-2751:
----------------------------------
Testing JIRA OOZIE-2751
Cleaning local git workspace
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than
132
. {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:red}-1{color} There are [7] new bugs found below threshold in total that
must be fixed.
. {color:red}-1{color} There are [7] new bugs found below threshold in
[core] that must be fixed.
. You can find the FindBugs diff here (look for the red and orange ones):
core/findbugs-new.html
. The most important FindBugs errors are:
. At V0JobsServlet.java:[line 100]: Dead store to json in
org.apache.oozie.servlet.V0JobsServlet.getJobs(HttpServletRequest)
. At V1JobsServlet.java:[line 364]: Dead store to json in
org.apache.oozie.servlet.V1JobsServlet.getBundleJobs(HttpServletRequest)
. At V1JobsServlet.java:[line 340]: Dead store to json in
org.apache.oozie.servlet.V1JobsServlet.getCoordinatorJobs(HttpServletRequest)
. At V1JobsServlet.java:[line 312]: Dead store to json in
org.apache.oozie.servlet.V1JobsServlet.getWorkflowJobs(HttpServletRequest)
. Method invoked at V1JobsServlet.java:[line 551]: Null passed for nonnull
parameter of
org.apache.oozie.OozieJsonFactory.getBundleJSONObject(BundleJobInfo, String) in
org.apache.oozie.servlet.V1JobsServlet.bulkModifyJobs(HttpServletRequest,
HttpServletResponse)
. Known null at V1JobsServlet.java:[line 543]: Null value at
V1JobsServlet.java:[line 524]
. Method invoked at V1JobsServlet.java:[line 581]: Null passed for nonnull
parameter of
org.apache.oozie.OozieJsonFactory.getCoordJSONObject(CoordinatorJobInfo,
String) in
org.apache.oozie.servlet.V1JobsServlet.bulkModifyJobs(HttpServletRequest,
HttpServletResponse)
. Known null at V1JobsServlet.java:[line 573]: Null value at
V1JobsServlet.java:[line 554]
. Method invoked at V1JobsServlet.java:[line 521]: Null passed for nonnull
parameter of org.apache.oozie.OozieJsonFactory.getWFJSONObject(WorkflowsInfo,
String) in
org.apache.oozie.servlet.V1JobsServlet.bulkModifyJobs(HttpServletRequest,
HttpServletResponse)
. Known null at V1JobsServlet.java:[line 513]: Null value at
V1JobsServlet.java:[line 497]
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in
[hadooplibs/hadoop-utils-2].
. {color:green}+1{color} There are no new bugs found in [client].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
. {color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
. {color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
. Tests run: 1831
. Tests failed: 7
. Tests errors: 5
. The patch failed the following testcases:
.
testMemoryUsageAndSpeed(org.apache.oozie.service.TestPartitionDependencyManagerService)
.
testMemoryUsageAndSpeed(org.apache.oozie.service.TestPartitionDependencyManagerEhcache)
. testPigScript(org.apache.oozie.action.hadoop.TestPigMainWithOldAPI)
. testPigScript(org.apache.oozie.action.hadoop.TestPigMain)
. testPig_withNullExternalID(org.apache.oozie.action.hadoop.TestPigMain)
. testEmbeddedPigWithinPython(org.apache.oozie.action.hadoop.TestPigMain)
. testMain(org.apache.oozie.action.hadoop.TestHiveMain)
. Tests failing with errors:
. testAddXIncludeFromStream(org.apache.oozie.util.TestXConfiguration)
. testAddXIncludeFromReader(org.apache.oozie.util.TestXConfiguration)
. testJMXInstrumentation(org.apache.oozie.util.TestMetricsInstrumentation)
. testStatus(org.apache.oozie.servlet.TestV1AdminServlet)
. testLoadDump(org.apache.oozie.tools.TestDBLoadDump)
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3488/
> LocalOozieClient is missing methods from OozieClient
> ----------------------------------------------------
>
> Key: OOZIE-2751
> URL: https://issues.apache.org/jira/browse/OOZIE-2751
> Project: Oozie
> Issue Type: Bug
> Reporter: Robert Kanter
> Assignee: Abhishek Bafna
> Fix For: 5.0.0
>
> Attachments: OOZIE-2751-00.patch, OOZIE-2751-01.patch
>
>
> {{LocalOozieClient}} works by wrapping direct calls to {{DagEngine}} in the
> normal {{OozieClient}} methods instead of making REST calls to an Oozie
> Server. However, it currently doesn't override all methods, which means you
> hit the {{OozieClient}} implementation, which tries to make a REST call and
> will fail (because it's not setup for that). For example, {{getStatus(String
> jobId)}} isn't overridden, and doesn't work when used from
> {{LocalOozieClient}}.
> We should also create a test that verifies that all methods are overridden.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
