----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69988/#review212832 -----------------------------------------------------------
bin/test-patch-11-findbugs-diff Line 1 (original), 1 (patched) <https://reviews.apache.org/r/69988/#comment298747> Can you please check the script with shellcheck bin/test-patch-11-findbugs-diff Lines 28-29 (original), 28-29 (patched) <https://reviews.apache.org/r/69988/#comment298748> If we change the order of the variables, we don't need to enter the jar name twice. bin/test-patch-11-findbugs-diff Line 238 (original), 238 (patched) <https://reviews.apache.org/r/69988/#comment298749> Couldn't we use SPOTBUGS_XML_NAME here? bin/test-patch-11-findbugs-diff Line 275 (original), 275 (patched) <https://reviews.apache.org/r/69988/#comment298753> Can we change the name to spotbugs-new.xml? Or maybe it's hardwired somewhere else? bin/test-patch-11-findbugs-diff Line 331 (original), 331 (patched) <https://reviews.apache.org/r/69988/#comment298754> Even if we don't change the name, we could put it into a variable and reuse it here. core/pom.xml Lines 19 (patched) <https://reviews.apache.org/r/69988/#comment298723> Please delete dead code fluent-job/fluent-job-api/pom.xml Line 80 (original), 80 (patched) <https://reviews.apache.org/r/69988/#comment298752> Should we keep this filename? fluent-job/pom.xml Lines 44 (patched) <https://reviews.apache.org/r/69988/#comment298722> Do we really need the version number here? There is no version number in `core/pom.xml` pom.xml Lines 1632 (patched) <https://reviews.apache.org/r/69988/#comment298719> Please store the version number in a variable, so we can avoid repeating it multiple times. pom.xml Line 1798 (original), 1805 (patched) <https://reviews.apache.org/r/69988/#comment298718> Please store the version number in a variable, so we can avoid repeating it multiple times. pom.xml Line 1860 (original), 1866 (patched) <https://reviews.apache.org/r/69988/#comment298720> Please store the version number in a variable, so we can avoid repeating it multiple times. pom.xml Line 1865 (original), 1871 (patched) <https://reviews.apache.org/r/69988/#comment298746> Why is it called findbug? Compatibility reasons? pom.xml Line 1908 (original), 1914 (patched) <https://reviews.apache.org/r/69988/#comment298721> Please store the version number in a variable, so we can avoid repeating it multiple times. - Andras Salamon On Feb. 14, 2019, 4:51 p.m., Kinga Marton wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69988/ > ----------------------------------------------------------- > > (Updated Feb. 14, 2019, 4:51 p.m.) > > > Review request for oozie and Andras Salamon. > > > Repository: oozie-git > > > Description > ------- > > https://gleclaire.github.io/findbugs-maven-plugin/ > > Status: Since Findbugs is no longer maintained, please use Spotbugs which has > a Maven plugin. > > The plugin author recommends to migrate to Spotbugs: > https://spotbugs.github.io/ > It might worth to investigate this plugin. > > > Diffs > ----- > > bin/test-patch-11-findbugs-diff c884daaa3 > client/pom.xml f0f6a1b13 > core/pom.xml b6c07d345 > fluent-job/fluent-job-api/pom.xml f303b4583 > fluent-job/pom.xml bb8861d59 > pom.xml 93fffc791 > sharelib/git/pom.xml 1c17e48ba > sharelib/oozie/pom.xml a53d335f9 > sharelib/spark/pom.xml 76f69034e > tools/pom.xml 72a6c283a > > > Diff: https://reviews.apache.org/r/69988/diff/1/ > > > Testing > ------- > > Tested manually > > > Thanks, > > Kinga Marton > >
