----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69988/#review213025 -----------------------------------------------------------
bin/test-patch-11-findbugs-diff Line 118 (original), 119 (patched) <https://reviews.apache.org/r/69988/#comment298879> I think the correct way to make both shellcheck and maven happy is the following: ${MVNPASSTHRU:+"${MVNPASSTHRU}"} Probably it's better to just ignore it. bin/test-patch-11-findbugs-diff Lines 186-187 (original), 187-188 (patched) <https://reviews.apache.org/r/69988/#comment298875> Shellcheck gives the following error: SC2128: Expanding an array without an index only gives the first element. Why do we need an array here? Shouldn't we use a simple md5Content="$(md5sum "${DIFF_DIR}/${FINDBUGS_JAR}")" instead? bin/test-patch-11-findbugs-diff Line 202 (original), 203 (patched) <https://reviews.apache.org/r/69988/#comment298876> Shellcheck warning is correct, moreover it is not even a valid command: $ echo "aaa" < cat /tmp/alma.txt -bash: cat: No such file or directory The correct syntax: $ echo "aaa $(cat /tmp/alma.txt)" aaa alma Or we can just print out a simple error message without printing out the value of the md5. It's not that helpful information. bin/test-patch-11-findbugs-diff Line 204 (original), 205 (patched) <https://reviews.apache.org/r/69988/#comment298877> Just like above, this is an invalid command. bin/test-patch-11-findbugs-diff Line 281 (original), 282 (patched) <https://reviews.apache.org/r/69988/#comment298878> Let's just ignore the shellcheck warning here, this is too complex. - Andras Salamon On Feb. 20, 2019, 5:47 p.m., Kinga Marton wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69988/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2019, 5:47 p.m.) > > > Review request for oozie and Andras Salamon. > > > Repository: oozie-git > > > Description > ------- > > https://gleclaire.github.io/findbugs-maven-plugin/ > > Status: Since Findbugs is no longer maintained, please use Spotbugs which has > a Maven plugin. > > The plugin author recommends to migrate to Spotbugs: > https://spotbugs.github.io/ > It might worth to investigate this plugin. > > > Diffs > ----- > > bin/test-patch-11-findbugs-diff c884daaa3 > client/pom.xml f0f6a1b13 > core/pom.xml b6c07d345 > fluent-job/fluent-job-api/findbugs-filter.xml > fluent-job/fluent-job-api/pom.xml f303b4583 > fluent-job/pom.xml bb8861d59 > pom.xml d817140f1 > sharelib/git/pom.xml 1c17e48ba > sharelib/oozie/pom.xml a53d335f9 > sharelib/spark/pom.xml 76f69034e > tools/pom.xml 72a6c283a > > > Diff: https://reviews.apache.org/r/69988/diff/3/ > > > Testing > ------- > > Tested manually > > > Thanks, > > Kinga Marton > >
