[
https://issues.apache.org/jira/browse/OPENJPA-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679427#action_12679427
]
Pinaki Poddar commented on OPENJPA-891:
---------------------------------------
Few minor suggestions/comments:
1. A new method isRecoverable() method is added in one of the OpenJPA Exception
class. There is an existing isFatal() method which had similar semantics. Could
that have sufficed instead of the new method? If not, then what is the semantic
difference and it may be documented for the newly added method.
2. Naming (in classes, in configuration) that uses 'jpa2' does somehow looks
awkward. It will perhaps make less sense in 2012 when newer JPA version is
available and no significant change has happened in an area to warranty a
*JPA6*.java. As a rule of thumb, perhaps a naming scheme that is explanatory of
its function rather than its compliance to a spec version is a more
long-lasting approach.
3. SQLExceptions
Newly added method used OpenJPAConfiguration but appears in method signature
4. LockException
Should have constructor with new lockLevel argument as in the case of
existing state variables.
> JPA2 LockTypeMode Support
> -------------------------
>
> Key: OPENJPA-891
> URL: https://issues.apache.org/jira/browse/OPENJPA-891
> Project: OpenJPA
> Issue Type: Sub-task
> Components: jpa
> Affects Versions: 2.0.0
> Reporter: Albert Lee
> Assignee: Albert Lee
> Fix For: 2.0.0
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
