[ 
https://issues.apache.org/jira/browse/OPENJPA-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679994#action_12679994
 ] 

Albert Lee commented on OPENJPA-891:
------------------------------------

Pinaki,

Thanks for the comments.

>> 1 & 4
Fixed.

>>2. Naming (in classes, in configuration) that uses 'jpa2' does somehow looks 
>>awkward. It will perhaps make less sense in 2012 when newer JPA version is 
>>available and no significant change has happened in an area to warranty a 
>>*JPA6*.java. As a rule of thumb, perhaps a naming scheme that is explanatory 
>>of its function rather than its compliance to a spec version is a more 
>>long-lasting approach.

Agree. What would be a good choice? I am thinking the following:
- mixed
- miximistic (mix of both optimistic and pessimistic)
- combomistic (comination of both)
- jpa

>> 3. SQLExceptions
   Newly added method used OpenJPAConfiguration but appears in method signature

Not sure what this is referring to. There is a methods that needs the 
OpenJPAConfiguration to access the lock manager. The other is a convenient 
method with StateManager as agrument that calls the first method to do the same 
thing.

Albert Lee.

> JPA2 LockTypeMode Support
> -------------------------
>
>                 Key: OPENJPA-891
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-891
>             Project: OpenJPA
>          Issue Type: Sub-task
>          Components: jpa
>    Affects Versions: 2.0.0
>            Reporter: Albert Lee
>            Assignee: Albert Lee
>             Fix For: 2.0.0
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to