rmannibucau commented on a change in pull request #92:
URL: https://github.com/apache/openjpa/pull/92#discussion_r772892281



##########
File path: openjpa-all/pom.xml
##########
@@ -110,6 +110,7 @@
                                         <Specification-Title>JSR-338 Java 
Persistence</Specification-Title>
                                         <Specification-Vendor>ORACLE, 
Inc.</Specification-Vendor>
                                         
<Specification-Version>2.2</Specification-Version>
+                                        
<Automatic-Module-Name>org.apache.openjpa.all</Automatic-Module-Name>

Review comment:
       Well I would really use github cause mvnrepo just indexes central and 
very few projects are released to central (guess central download stats are an 
alternative approach which can be better). We are at 40% for the fatjar, 11 for 
the karaf feature and rest is distributed <= 7% between other artifacts so our 
assumption was right, let's name the module only for the fatjar :).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openjpa.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to