rmannibucau commented on a change in pull request #92:
URL: https://github.com/apache/openjpa/pull/92#discussion_r771466419
##########
File path: openjpa-all/pom.xml
##########
@@ -110,6 +110,7 @@
<Specification-Title>JSR-338 Java
Persistence</Specification-Title>
<Specification-Vendor>ORACLE,
Inc.</Specification-Vendor>
<Specification-Version>2.2</Specification-Version>
+
<Automatic-Module-Name>org.apache.openjpa.all</Automatic-Module-Name>
Review comment:
openjpa is a modular project, you can use individual jar. It is common
to use the fat bundle but it leads to break JPMS as explained so we should
choose if we provide JPMS for modules or just for the fatjar (or nobody ;)).
What we must not do is to provide not stable names regarding packages (ignore
the .jar, only packages are important and your module-info should be stable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@openjpa.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
