rmannibucau commented on a change in pull request #92:
URL: https://github.com/apache/openjpa/pull/92#discussion_r772884796
##########
File path: openjpa-all/pom.xml
##########
@@ -110,6 +110,7 @@
<Specification-Title>JSR-338 Java
Persistence</Specification-Title>
<Specification-Vendor>ORACLE,
Inc.</Specification-Vendor>
<Specification-Version>2.2</Specification-Version>
+
<Automatic-Module-Name>org.apache.openjpa.all</Automatic-Module-Name>
Review comment:
Yes, some do and break users (unintentionally from the ones I saw -
mainly a "put automatic names everywhere" without caring about consumer side
:().
The topic is interesting and joins another one: should our fatjar be the
recommended one or should we promote the modular approach? Once this question
answered we just put automatic names - or real module-info - in these modules.
One approach is to get stats from public github repos using openjpa.
I tend to think like you but without figures it is quite hypothetic IMHO.
Wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@openjpa.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
