Perhaps we could include pom.xml for the api in the omod? Would that be wrong somehow?
-Darius On Fri, Oct 28, 2011 at 7:48 AM, Ben Wolfe <[email protected]> wrote: > The omod file includes the module-api jar file in its lib folder. So it > would be very simple for the module repository to pull that out and publish > to the repository. > > The tricky part would be constructing the pom that went along with it. Or > will the mavenrepo figure that out from the jar and its metainf files? > > The bigger question is, do we add this feature into our module repository > or include this as "one more thing" to add once we switch to a different > module repository software? > > Ben > > > On Mon, Sep 26, 2011 at 6:41 PM, Burke Mamlin <[email protected]>wrote: > >> Surely there's enough information in the omod to whittle it down to a JAR. >> If there isn't, I would propose adding any metadata needed (e.g., the list >> of what belongs in the JAR or just the subset that differs from convention) >> into the omod (e.g., as a file in META-INF) so an automated process like the >> module repository can programmatically derive the maven artifact JAR from >> the omod. The easier we make it for developers to do the right thing, the >> better. >> >> -Burke >> >> >> On Mon, Sep 26, 2011 at 9:55 AM, Mark Goodrich <[email protected]> wrote: >> >>> Having a “one-click” process sounds good to me… although we would have to >>> upload both the jar and the omod to the module repository, since, as >>> Saptarshi mentioned a jar and a omod for a module are not necessarily >>> identical.**** >>> >>> ** ** >>> >>> @Saptarshi—if we add the dependency management section to the poms, is >>> the “mvn deploy” goal separate from the “mvn release:prepare” goal? I >>> wouldn’t want a “mvn relase:prepare” goal to fail just because a user >>> doesn’t have commit rights to the Openmrs Maven repo.**** >>> >>> ** ** >>> >>> Mark **** >>> >>> ** ** >>> >>> *From:* [email protected] [mailto:[email protected]] *On Behalf Of *Saptarshi >>> Purkayastha >>> *Sent:* Saturday, September 24, 2011 12:08 AM >>> >>> *To:* [email protected] >>> *Subject:* Re: [OPENMRS-DEV] FW: Installing modules to Openmrs Maven >>> Repo**** >>> >>> ** ** >>> >>> Roger's warning about malicious stuff propagating faster through >>> libraries updated to the maven repository does hold some ground... and hence >>> think that it is a good idea to upload the artifacts through a one-click >>> process of uploading it to our module repository and automatically copying >>> it to the maven repository. This has a couple of advantages:**** >>> >>> ** ** >>> >>> - Saves the headache of knowing maven's intricacies**** >>> >>> - Protect other uploaded artifacts from mismatched or incorrect versions >>> uploaded by other users**** >>> >>> ** ** >>> >>> Other projects/repos have something called as a staging maven repository >>> where anyone can upload and then maven administrators for the project move >>> things from staging to main repos as and when they feel it is stable and a >>> lot of users are using it happily.**** >>> >>> ** ** >>> >>> If we have the one-click process, then all things are nice and happy. We >>> would have to create a kind of connector that will automate the process of >>> adding to the repo filesystem and rebuild the nexus metadata.**** >>> >>> On the other hand, if we don't have the one-click process, then we have >>> to add the: <dependencyManagement> section to the poms of modules that are >>> maven built... especially the basicmodule and recently complete GSoC proj on >>> maven archetypes**** >>> >>> >>> http://maven.apache.org/plugins/maven-deploy-plugin/usage.html#The_deploy:deploy_Mojo >>> **** >>> >>> ** ** >>> >>> ** ** >>> >>> PS: I am pretty sure not every omod is equal to jar... or atleast we >>> shouldn't hope it to be. Most modules could just publish the *api.jar >>> instead of *.omod**** >>> >>> >>> --- >>> Regards, >>> Saptarshi PURKAYASTHA >>> >>> My Tech Blog: http://sunnytalkstech.blogspot.com >>> You Live by CHOICE, Not by CHANCE >>> >>> **** >>> >>> On 23 September 2011 18:36, Friedman, Roger (CDC/CGH/DGHA) (CTR) < >>> [email protected]> wrote:**** >>> >>> Doesn’t the right to put modules in the repository come with the right to >>> put malware-carrying versions of the modules there, potentially infecting >>> every build.**** >>> >>> **** >>> >>> *From:* [email protected] [mailto:[email protected]] *On Behalf Of *Burke >>> Mamlin >>> *Sent:* Thursday, September 22, 2011 12:46 PM**** >>> >>> >>> *To:* [email protected] >>> *Subject:* Re: [OPENMRS-DEV] FW: Installing modules to Openmrs Maven >>> Repo**** >>> >>> **** >>> >>> I think we should err on the side of making it easy for people (anyone >>> with an OpenMRS ID) to contribute to the maven repository until/unless it >>> becomes a problem that needs more oversight (e.g., special privileges, which >>> could be manually or auto-magically assigned based on merit/karma).**** >>> >>> **** >>> >>> Ideally, we'd adopt a convention of any modules in the repository using >>> tagged releases, since unversioned dependencies (i.e., unversioned artifacts >>> in maven) will cause a lot more headaches downstream than it will for the >>> module author to do up front.[1]**** >>> >>> **** >>> >>> -Burke**** >>> >>> **** >>> >>> [1] "Module Branching" https://wiki.openmrs.org/x/TRIz**** >>> >>> **** >>> >>> On Thu, Sep 22, 2011 at 10:23 AM, Mark Goodrich <[email protected]> >>> wrote:**** >>> >>> I downloaded and built the proper jars for 3 of the 4 modules I asked >>> Saptarshi to commit to the repository. Sorry Saptarshi, but I created >>> another ticket with these three jars.**** >>> >>> **** >>> >>> Unfortunately, the htmlwidgets module does not have tagged releases, so >>> hopefully we can live with a jar that is simply renamed omod.**** >>> >>> **** >>> >>> This was a little annoying to have go back and do, so it would definitely >>> be great if we can use the release plugin to automate this.**** >>> >>> **** >>> >>> Mark**** >>> >>> **** >>> >>> **** >>> >>> **** >>> >>> *From:* [email protected] [mailto:[email protected]] *On Behalf Of *Mark >>> Goodrich >>> *Sent:* Tuesday, September 20, 2011 12:36 PM**** >>> >>> >>> *To:* [email protected] >>> *Subject:* Re: [OPENMRS-DEV] FW: Installing modules to Openmrs Maven >>> Repo**** >>> >>> **** >>> >>> I will take a look in svn and see what I can find in terms of tagged >>> releases.**** >>> >>> **** >>> >>> Mark**** >>> >>> **** >>> >>> *From:* [email protected] [mailto:[email protected]] *On Behalf Of *Darius >>> Jazayeri >>> *Sent:* Tuesday, September 20, 2011 10:44 AM >>> *To:* [email protected] >>> *Subject:* Re: [OPENMRS-DEV] FW: Installing modules to Openmrs Maven >>> Repo**** >>> >>> **** >>> >>> So...those are not necessarily the right jars...**** >>> >>> **** >>> >>> If a module developer is following good practices, they'll have the >>> releases tagged in svn. So in those cases we should be able to check out the >>> tags, build the jars from those, and add those to nexus.**** >>> >>> **** >>> >>> Ben, can the maven release plugin help with this?**** >>> >>> **** >>> >>> -Darius**** >>> >>> On Tue, Sep 20, 2011 at 7:35 AM, Mark Goodrich <[email protected]> >>> wrote:**** >>> >>> Is there is a way to get a certain version of a jar for a module, short >>> of figuring out what rev the released omod was built from, checking out that >>> revision, and compiling the jar?**** >>> >>> **** >>> >>> FWIW, for the modules that Saptarshi installed to Maven repo, I simply >>> downloaded the omods from the repository, renamed them to .jar, and posted >>> them to the ticket.**** >>> >>> **** >>> >>> We should change the wiki once we figure out what the correct procedure >>> should be:**** >>> >>> **** >>> >>> >>> https://wiki.openmrs.org/display/docs/Requiring+another+module+in+your+module >>> **** >>> >>> **** >>> >>> Mark**** >>> >>> **** >>> >>> **** >>> >>> **** >>> >>> **** >>> >>> *From:* [email protected] [mailto:[email protected]] *On Behalf Of *Ben >>> Wolfe >>> *Sent:* Tuesday, September 20, 2011 2:42 AM**** >>> >>> >>> *To:* [email protected] >>> *Subject:* Re: [OPENMRS-DEV] FW: Installing modules to Openmrs Maven >>> Repo**** >>> >>> **** >>> >>> We need a project in jira where these types of requests can go. I've >>> requested one here: https://tickets.openmrs.org/browse/ITSM-1853 >>> >>> Omods are jar files, yes, but a jar file for a module is different. The >>> jar file does not contain the config, jsp, images, etc files that are >>> necessary for the web layer that the omod does (as Mark points out). >>> >>> It is possible to compile a module as a jar instead of an omod, and that >>> is what should be in the maven repo. >>> >>> Ben**** >>> >>> On Mon, Sep 19, 2011 at 5:08 PM, Mark Goodrich <[email protected]> >>> wrote:**** >>> >>> Saptashi—**** >>> >>> **** >>> >>> I went and created a ticket for this… thanks for offering to do this!*** >>> * >>> >>> **** >>> >>> https://tickets.openmrs.org/browse/TODO-19**** >>> >>> **** >>> >>> Mark**** >>> >>> **** >>> >>> **** >>> >>> **** >>> >>> *From:* [email protected] [mailto:[email protected]] *On Behalf Of *Saptarshi >>> Purkayastha >>> *Sent:* Friday, September 16, 2011 6:19 PM**** >>> >>> >>> *To:* [email protected]**** >>> >>> *Subject:* Re: [OPENMRS-DEV] FW: Installing modules to Openmrs Maven >>> Repo**** >>> >>> **** >>> >>> Is there a ticket to claim??**** >>> >>> I can upload it to the maven repo and have the necessary permissions**** >>> >>> >>> --- >>> Regards, >>> Saptarshi PURKAYASTHA >>> >>> My Tech Blog: http://sunnytalkstech.blogspot.com >>> You Live by CHOICE, Not by CHANCE**** >>> >>> On 17 September 2011 03:15, Mark Goodrich <[email protected]> wrote:**** >>> >>> Bumping this up. What are people's thoughts on this? I'd be willing to >>> upload the needed jars to the Openmrs Maven Repo if someone can give me an >>> account...**** >>> >>> >>> Mark >>> >>> >>> -----Original Message----- >>> From: [email protected] [mailto:[email protected]] On Behalf Of Michael >>> Downey >>> Sent: Thursday, September 15, 2011 3:38 PM >>> To: [email protected] >>> Subject: Re: [OPENMRS-DEV] Installing modules to Openmrs Maven Repo >>> >>> Hi Mark, >>> >>> On Thu, Sep 15, 2011 at 3:40 PM, Mark Goodrich <[email protected]> >>> wrote: >>> > In the wiki, it says that I should open a ITSM ticket in jira to >>> request new modules be added to the Maven repo. I can do this but does >>> anyone have any insight or preference as to what versions of the jars we >>> should install? >>> >>> The development team handles all the content in Nexus -- we only keep it >>> running. :-) >>> >>> Michael Downey >>> OpenMRS Community Infrastructure Team >>> [email protected] - http://openmrs.org/ >>> >>> _________________________________________**** >>> >>> -----Original Message----- >>> From: Mark Goodrich >>> Sent: Thursday, September 15, 2011 3:40 PM >>> To: '[email protected]' >>> Subject: Installing modules to Openmrs Maven Repo >>> >>> I'm going through the process of mavenizing the MDR-TB module, and the >>> module depends on both the logic module and the reporting module. I've >>> installed these two modules to my local repository, but the next step is to >>> install these modules to the Openmrs Maven Repo.**** >>> >>> In the wiki, it says that I should open a ITSM ticket in jira to request >>> new modules be added to the Maven repo. I can do this but does anyone have >>> any insight or preference as to what versions of the jars we should >>> install?**** >>> >>> Mark**** >>> >>> **** >>> >>> >> ------------------------------ >> Click here to >> unsubscribe<[email protected]?body=SIGNOFF%20openmrs-devel-l>from >> OpenMRS Developers' mailing list >> > > ------------------------------ > Click here to > unsubscribe<[email protected]?body=SIGNOFF%20openmrs-devel-l>from > OpenMRS Developers' mailing list > _________________________________________ To unsubscribe from OpenMRS Developers' mailing list, send an e-mail to [email protected] with "SIGNOFF openmrs-devel-l" in the body (not the subject) of your e-mail. [mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l]
