rzo1 commented on code in PR #778:
URL: https://github.com/apache/opennlp/pull/778#discussion_r2073996297
##########
opennlp-tools/src/test/java/opennlp/tools/monitoring/DefaultTrainingProgressMonitorTest.java:
##########
@@ -21,42 +21,32 @@
import java.util.Map;
import ch.qos.logback.classic.Level;
-import ch.qos.logback.classic.Logger;
import ch.qos.logback.classic.spi.ILoggingEvent;
-import ch.qos.logback.core.read.ListAppender;
-import org.junit.jupiter.api.AfterAll;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
-import org.slf4j.LoggerFactory;
+import org.junit.jupiter.api.TestInstance;
+import opennlp.tools.AbstractLoggerTest;
import opennlp.tools.util.TrainingParameters;
-import static java.util.stream.Collectors.toList;
import static org.junit.jupiter.api.Assertions.assertArrayEquals;
import static org.junit.jupiter.api.Assertions.assertEquals;
-class DefaultTrainingProgressMonitorTest {
-
- private static final String LOGGER_NAME = "opennlp";
- private static final Logger logger = (Logger)
LoggerFactory.getLogger(LOGGER_NAME);
- private static final Level originalLogLevel = logger != null ?
logger.getLevel() : Level.OFF;
+@TestInstance(TestInstance.Lifecycle.PER_CLASS)
+class DefaultTrainingProgressMonitorTest extends AbstractLoggerTest {
Review Comment:
Might be possible to use `log-captor` here as well?
##########
opennlp-tools/src/test/resources/opennlp/tools/cmdline/languagemodel/sentences_set_1.txt:
##########
Review Comment:
Can you state the source of this text material? We should mention it (afaik
there is a file holding references to the text sources).
##########
opennlp-tools/src/test/java/opennlp/tools/AbstractLoggerTest.java:
##########
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package opennlp.tools;
+
+import java.util.Objects;
+
+import ch.qos.logback.classic.Level;
+import ch.qos.logback.classic.Logger;
+import ch.qos.logback.classic.spi.ILoggingEvent;
+import ch.qos.logback.core.read.ListAppender;
+import org.junit.jupiter.api.AfterAll;
+import org.slf4j.LoggerFactory;
+
+/**
+ * An abstract class to configure a {@link Logger} instance with a test {@link
ListAppender}
+ * to help with unit-testing.
+ */
+public abstract class AbstractLoggerTest {
Review Comment:
We have https://github.com/Hakky54/log-captor in the (test) classpath. Why
not use it for this use-case?
With log-captor it should be possible to avoid the logback stuff, no?
##########
opennlp-tools/src/test/resources/opennlp/tools/cmdline/languagemodel/sentences_set_2.txt:
##########
@@ -0,0 +1,11 @@
+In January 1969 only the most optimistic could have predicted that in just six
months time humans would be walking on the surface of the Moon
Review Comment:
See the other comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
