mawiesne commented on code in PR #778: URL: https://github.com/apache/opennlp/pull/778#discussion_r2079932676
########## opennlp-tools/src/test/resources/opennlp/tools/cmdline/languagemodel/sentences_set_1.txt: ########## Review Comment: Pls drop a short comment / url in a file named `origin_of_text_samples.txt` in `../src/test/resources/opennlp/tools/cmdline/languagemodel/` ########## opennlp-tools/src/test/java/opennlp/tools/AbstractLoggerTest.java: ########## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package opennlp.tools; + +import java.util.Objects; + +import ch.qos.logback.classic.Level; +import ch.qos.logback.classic.Logger; +import ch.qos.logback.classic.spi.ILoggingEvent; +import ch.qos.logback.core.read.ListAppender; +import org.junit.jupiter.api.AfterAll; +import org.slf4j.LoggerFactory; + +/** + * An abstract class to configure a {@link Logger} instance with a test {@link ListAppender} + * to help with unit-testing. + */ +public abstract class AbstractLoggerTest { Review Comment: I agree ########## opennlp-tools/src/test/java/opennlp/tools/monitoring/DefaultTrainingProgressMonitorTest.java: ########## @@ -21,42 +21,32 @@ import java.util.Map; import ch.qos.logback.classic.Level; -import ch.qos.logback.classic.Logger; import ch.qos.logback.classic.spi.ILoggingEvent; -import ch.qos.logback.core.read.ListAppender; -import org.junit.jupiter.api.AfterAll; import org.junit.jupiter.api.BeforeAll; import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; -import org.slf4j.LoggerFactory; +import org.junit.jupiter.api.TestInstance; +import opennlp.tools.AbstractLoggerTest; import opennlp.tools.util.TrainingParameters; -import static java.util.stream.Collectors.toList; import static org.junit.jupiter.api.Assertions.assertArrayEquals; import static org.junit.jupiter.api.Assertions.assertEquals; -class DefaultTrainingProgressMonitorTest { - - private static final String LOGGER_NAME = "opennlp"; - private static final Logger logger = (Logger) LoggerFactory.getLogger(LOGGER_NAME); - private static final Level originalLogLevel = logger != null ? logger.getLevel() : Level.OFF; +@TestInstance(TestInstance.Lifecycle.PER_CLASS) +class DefaultTrainingProgressMonitorTest extends AbstractLoggerTest { private TrainingProgressMonitor progressMonitor; - private final ListAppender<ILoggingEvent> appender = new ListAppender<>(); - @BeforeAll - static void beforeAll() { - logger.setLevel(Level.INFO); + protected void beforeAll() { Review Comment: I wonder why the @BeforeAll method is not `static`. Did some value of `x` in JUnit 5.x change this? ########## opennlp-tools/src/test/resources/opennlp/tools/languagemodel/sentences.txt: ########## @@ -1,7 +1,7 @@ The word2vec software of Tomas Mikolov and colleagues has gained a lot of traction lately and provides state-of-the-art word embeddings The learning models behind the software are described in two research papers We found the description of the models in these papers to be somewhat cryptic and hard to follow -While the motivations and presentation may be obvious to the neural-networks language-mofdeling crowd we had to struggle quite a bit to figure out the rationale behind the equations Review Comment: That's an interesting find! 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
