NishantShri4 commented on code in PR #778: URL: https://github.com/apache/opennlp/pull/778#discussion_r2082987517
########## opennlp-tools/src/test/java/opennlp/tools/AbstractLoggerTest.java: ########## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package opennlp.tools; + +import java.util.Objects; + +import ch.qos.logback.classic.Level; +import ch.qos.logback.classic.Logger; +import ch.qos.logback.classic.spi.ILoggingEvent; +import ch.qos.logback.core.read.ListAppender; +import org.junit.jupiter.api.AfterAll; +import org.slf4j.LoggerFactory; + +/** + * An abstract class to configure a {@link Logger} instance with a test {@link ListAppender} + * to help with unit-testing. + */ +public abstract class AbstractLoggerTest { Review Comment: Thanks for the suggestions. I have updated it to use logcaptor. However, using logcaptor still needs switching-on the logging level to INFO to capture logs. sfl4j doesn't seem to provide an API method to toggle the logging level. Hence needed to use logback (which offers such an api). The logic to switch-on/restore logging levels remains limited to this abstract class only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
