NishantShri4 commented on code in PR #778:
URL: https://github.com/apache/opennlp/pull/778#discussion_r2082994846
##########
opennlp-tools/src/test/java/opennlp/tools/monitoring/DefaultTrainingProgressMonitorTest.java:
##########
@@ -21,42 +21,32 @@
import java.util.Map;
import ch.qos.logback.classic.Level;
-import ch.qos.logback.classic.Logger;
import ch.qos.logback.classic.spi.ILoggingEvent;
-import ch.qos.logback.core.read.ListAppender;
-import org.junit.jupiter.api.AfterAll;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
-import org.slf4j.LoggerFactory;
+import org.junit.jupiter.api.TestInstance;
+import opennlp.tools.AbstractLoggerTest;
import opennlp.tools.util.TrainingParameters;
-import static java.util.stream.Collectors.toList;
import static org.junit.jupiter.api.Assertions.assertArrayEquals;
import static org.junit.jupiter.api.Assertions.assertEquals;
-class DefaultTrainingProgressMonitorTest {
-
- private static final String LOGGER_NAME = "opennlp";
- private static final Logger logger = (Logger)
LoggerFactory.getLogger(LOGGER_NAME);
- private static final Level originalLogLevel = logger != null ?
logger.getLevel() : Level.OFF;
+@TestInstance(TestInstance.Lifecycle.PER_CLASS)
+class DefaultTrainingProgressMonitorTest extends AbstractLoggerTest {
private TrainingProgressMonitor progressMonitor;
- private final ListAppender<ILoggingEvent> appender = new ListAppender<>();
-
@BeforeAll
- static void beforeAll() {
- logger.setLevel(Level.INFO);
+ protected void beforeAll() {
Review Comment:
Thanks for your suggestions.
I think Junit5 flexibly allows to keep @BeforeAll annotated methods as
non-static, provided @TestInstance is used (to manage test lifecycle).
This non-static usage allows overriding beforeAll(..) in child classes.
After using logcaptor and some other refactoring, there isn't a need to
override beforeAll(..).
Hence this is declared static now (in line with regular usuage).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
