The Release Candidate is good for production/GA:

[X] yes / +1

[ ] no / -1

My vote is based on

[X] binding (member of PMC)

[X] I have built and tested the RC from source on platform [ Linux x86-64 
(CentOS 7) ]

[X] I have tested the binary RC on platform [Windows 10, Linux x86-64 (CentOS 7 
& 8) ]

I used the en-US rpm install for Linux and the en-US exe for Windows and also installed the SDK for both platforms.

Verified checksums and signatures for these binaries and source tarballs.

Besides the usual testing of existing documents and creating new documents, I ran through an automated test program below.

--- Automated test results ---
Now that the tests in trunk are standalone I'm running them on systems I can't build on also.

I ran the automated Build Verification (49 tests) and the Functional Verification (744 tests) on Windows 10, CentOS 7 & 8. Due to still having a few tests that randomly fail due to timing or other issues I ran each suite 3 times.

Summary:
Only 3 tests failed all three times and these are issues with the tests themselves and not the office.

Details:
Test method bvt.gui.BasicFunctionTest.testFind had an assertion inadvertently changed during a spell checking cleanup causing it to fail.
I've have a fix for it that I'll commit in a while.

Test method fvt.uno.sc.formula.TestFormulaDocs.testFormulaDocs has a test document "uno/sc/fvt/Basic Line as variable and Line Input.ods" that tests a fix for Basic macros with single line IF statements from commit 725d867 that was never back-ported to AOO41X.

Test method fvt.uno.sc.sheet.SheetBasicTest.insertSheetFromfile must be a known failure because it has a comment:
// FIXME: locks up on update link confirmation dialog.
which causes a timeout failure.

Other than that everything looks fine.

Best regards,
Carl



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

Reply via email to