stiga-huang commented on a change in pull request #934: URL: https://github.com/apache/orc/pull/934#discussion_r728568371
########## File path: java/core/src/java/org/apache/orc/util/BloomFilter.java ########## @@ -246,6 +246,13 @@ public void reset() { this.bitSet.clear(); } + /** + * Helper method that only used for tests. Use default visibility. + */ + boolean testBitSetPos(int pos) { Review comment: I'm not sure if I understand the requirement. `bitSet` is a private member of `BloomFilter`. Do you mean changing `bitSet` from private to default visibility so we can use it directly in `TestBloomFilter#checkBitSet`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org