stiga-huang commented on a change in pull request #934:
URL: https://github.com/apache/orc/pull/934#discussion_r728570859
##########
File path: c++/src/Reader.hh
##########
@@ -179,6 +180,13 @@ namespace orc {
*/
void seekToRowGroup(uint32_t rowGroupEntryId);
+ /**
+ * Check if the file has bad bloom filters (ORC-1024). We will skip using
them in the
+ * following reads.
+ * @return true if it has.
+ */
+ bool checkBadBloomFilters();
Review comment:
Yeah, renaming it to `hasBadBloomFilters()` conflicts with the member
variable name. This is a private method in `RowReaderImpl` so it's not public
interface. Is it ok to keep this name? Or should I rename the member variable
to sth else?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
