dongjoon-hyun commented on a change in pull request #934:
URL: https://github.com/apache/orc/pull/934#discussion_r728662942
##########
File path: c++/src/Reader.cc
##########
@@ -35,6 +35,12 @@
#include <set>
namespace orc {
+ // ORC files writen by these versions of cpp writers have inconsistent bloom
filter
+ // hashing with the Java codes (ORC-1024). Bloom filters of them should not
be used
+ // after we fix ORC-1024.
Review comment:
@stiga-huang . It seems that you are confused. I didn't say to remove
comments. I asked you to remove JIRA ID.
> I can remove this if you prefer not having this comment.
If you want to be clear, you had better mention ORC version numbers
explicitly.
For coding style, I believe we both agree that the best coding style is
having clear and clean code and self-describing comments. Adding JIRA IDs means
redirecting to something-else due to the lack of clarity. I don't think this
code part has that kind complexity.
In addition, if you are adding JIRA IDs at every code blocks, we are going
to end up having JIRA IDs for all lines. Moreover, in the worst case, next
contributors are going to add another JIRA IDs for the same code blocks on top
of the existing JIRA IDs.
WDTY?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
