[GitHub] [orc] dongjoon-hyun commented on a change in pull request #934: ORC-1024: [C++] Fix inconsistent bloom filter hashing for numeric values

[GitBox]

dongjoon-hyun commented on a change in pull request #934:
URL: https://github.com/apache/orc/pull/934#discussion_r728668768



##########
File path: c++/src/Reader.cc
##########
@@ -243,6 +249,34 @@ namespace orc {
                                           footer->rowindexstride(),
                                           
getWriterVersionImpl(_contents.get())));
     }
+
+    hasBadBloomFilters = checkBadBloomFilters();
+  }
+
+  // Check if the file has inconsistent bloom filters (ORC-1024).
+  bool RowReaderImpl::checkBadBloomFilters() {
+    // Only C++ writer in old releases could have bad bloom filters.
+    if (footer->writer() != ORC_CPP_WRITER) return false;
+    // 'softwareVersion' is added in ORC-984 which is resolved in 1.5.13, 
1.6.11, and 1.7.0.

Review comment:
       ```java
   - // 'softwareVersion' is added in ORC-984 which is resolved in 1.5.13, 
1.6.11, and 1.7.0.
   + // 'softwareVersion' is added at 1.5.13, 1.6.11, and 1.7.0.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org