dongjoon-hyun commented on a change in pull request #990:
URL: https://github.com/apache/orc/pull/990#discussion_r781663936
##########
File path: c++/include/orc/Common.hh
##########
@@ -122,6 +122,19 @@ namespace orc {
StreamKind_BLOOM_FILTER_UTF8 = 8
};
+ /**
+ * Specific read intention when selecting a certain TypeId.
+ * This enum currently only being utilized by LIST type selection.
+ *
+ * TODO: extend this to support MAP and UNION type.
Review comment:
Apache ORC community recommends to use an IDed TODO with JIRA ID if
needed. For example,
```
- * TODO: extend this to support MAP and UNION type.
+ * TODO(ORC-XXX): extend this to support MAP and UNION type.
```
However, for this code, I'd like to recommend to remove this TODO and file
an ORC JIRA instead.
##########
File path: c++/include/orc/Common.hh
##########
@@ -122,6 +122,19 @@ namespace orc {
StreamKind_BLOOM_FILTER_UTF8 = 8
};
+ /**
+ * Specific read intention when selecting a certain TypeId.
+ * This enum currently only being utilized by LIST type selection.
+ *
+ * TODO: extend this to support MAP and UNION type.
Review comment:
Apache ORC community recommends to use an IDed TODO with JIRA ID if
needed. For example,
```
- * TODO: extend this to support MAP and UNION type.
+ * TODO(ORC-XXX): extend this to support MAP and UNION type.
```
However, for this code, I'd like to recommend to remove this TODO and file a
new ORC JIRA instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
