dongjoon-hyun commented on a change in pull request #990:
URL: https://github.com/apache/orc/pull/990#discussion_r781666272
##########
File path: c++/include/orc/Reader.hh
##########
@@ -149,6 +149,25 @@ namespace orc {
*/
RowReaderOptions& includeTypes(const std::list<uint64_t>& types);
+ /**
+ * A map type of <typeId, ReadIntent>.
+ */
+ typedef std::map<uint64_t, ReadIntent> TypeReadIntents;
+
+ /**
+ * Selects which type ids to read and specific ReadIntents for each
+ * type id. The root type is always 0 and the rest of the types are
Review comment:
`root type is always 0` might sound weird. Technically, `root type ID is
always 0`.
BTW, I'd like to recommend to remove this sentence, `The root type is always
0 and the rest of the types are labeled in a preorder traversal of the tree`
because this is redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
