hillsp commented on a change in pull request #1945: Grpc RpcHandler: Fix finish
before start behavior
URL:
https://github.com/apache/incubator-pagespeed-mod/pull/1945#discussion_r319572273
##########
File path: pagespeed/controller/rpc_handler.h
##########
@@ -196,6 +196,10 @@ void RpcHandler<AsyncService, RequestT,
ResponseT>::InitDone(RefPtrT ref) {
// Function).
// Note that the status from our Finish() call does not make it to the
// client in this case.
Review comment:
I don't think this comment about "not making it to the client" is right any
more.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
