hillsp commented on a change in pull request #1945: Grpc RpcHandler: Fix finish before start behavior URL: https://github.com/apache/incubator-pagespeed-mod/pull/1945#discussion_r319650160
########## File path: pagespeed/controller/rpc_handler.h ########## @@ -174,7 +174,7 @@ void RpcHandler<AsyncService, RequestT, ResponseT>::Start() { // "this" without calling HandleError(), because state_ is INIT. InitResponder(service_, &ctx_, &responder_, cq_, MakeFunction(this, &RpcHandler::InitDone, - &RpcHandler::CallHandleError, RefPtrT(this))); + &RpcHandler::CallHandleError, RefPtrT(this))); Review comment: I think you accidentally removed some whitespace here? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services