hillsp commented on a change in pull request #1945: Grpc RpcHandler: Fix finish
before start behavior
URL:
https://github.com/apache/incubator-pagespeed-mod/pull/1945#discussion_r319574528
##########
File path: pagespeed/controller/rpc_handler_test.cc
##########
@@ -580,13 +579,11 @@ TEST_F(RpcHandlerTest, DISABLED_FinishBeforeStart) {
// HandleRequest isn't called.
EXPECT_THAT(client_->reader_writer_->Write(req), Eq(true));
- // XXX(oschaaf): this hangs with the new grpc version.
- // commented it for now.
- //::grpc::Status status = client_->reader_writer_->Finish();
+ ::grpc::Status status = client_->reader_writer_->Finish();
// CANCELLED is generated by the gRPC library. There's no code in RpcHandler
Review comment:
CANCELLED isn't actually generated by the library any more. Maybe instead
say that it comes from RpcHandler::InitDone().
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
