hillsp commented on a change in pull request #1945: Grpc RpcHandler: Fix finish
before start behavior
URL:
https://github.com/apache/incubator-pagespeed-mod/pull/1945#discussion_r319652511
##########
File path: pagespeed/controller/rpc_handler.h
##########
@@ -189,13 +189,11 @@ void RpcHandler<AsyncService, RequestT,
ResponseT>::InitDone(RefPtrT ref) {
} else {
// When state is FINISHED, it shouldn't be possible for anything else to be
Review comment:
Ugh, sorry - another silly nit: You're not relying on the refcount to force
a disconnect - you're explicitly forcing it. I think it would be more correct
to say "When state is FINISHED, we were shutdown before we started. Propagate
that as CANCELLED to any client."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
