jmarantz commented on a change in pull request #1998:
URL:
https://github.com/apache/incubator-pagespeed-mod/pull/1998#discussion_r459141887
##########
File path: net/instaweb/rewriter/image_combine_filter_test.cc
##########
@@ -36,12 +36,12 @@ namespace net_instaweb {
namespace {
// Filenames of resource files.
-const char kBikePngFile[] = "BikeCrashIcn.png";
-const char kCuppaPngFile[] = "Cuppa.png";
-const char kPuzzleJpgFile[] = "Puzzle.jpg";
-const char kChefGifFile[] = "IronChef2.gif";
+constexpr absl::string_view kBikePngFile = "BikeCrashIcn.png";
Review comment:
ditto -- is this change necessary?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
