oschaaf commented on a change in pull request #1998:
URL:
https://github.com/apache/incubator-pagespeed-mod/pull/1998#discussion_r459356912
##########
File path: net/instaweb/rewriter/process_context.cc
##########
@@ -58,7 +58,7 @@ ProcessContext::ProcessContext()
// url/url_util.cc lazily initializes its "standard_schemes" table in a
// thread-unsafe way and so it must be explicitly initialized prior to thread
// creation, and explicitly terminated after thread quiescence.
- url::Initialize();
+ //url::Initialize();
Review comment:
I think we're good here. I double checked, and I couldn't find an
equivalent in the latest version, so I think it is safe to assume this is no
longer needed. I cleaned this up, and added some more cleanup + a fiasco fix in
https://github.com/apache/incubator-pagespeed-mod/pull/1998/commits/cca0fadb5f25fb46bf2e32ed94eee46ec85d17fe
(based on querying code level todo's I left in the last change).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
